[GitHub] [skywalking-java] wapkch commented on a diff in pull request #531: Fix possible IllegalStateException when using Micrometer

["wapkch (via GitHub)" <gi...@apache.org>]

wapkch commented on code in PR #531:
URL: https://github.com/apache/skywalking-java/pull/531#discussion_r1197254793


##########
apm-sniffer/apm-toolkit-activation/apm-toolkit-micrometer-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/micrometer/MicrometerReceiverTracingHandlerInterceptor.java:
##########
@@ -60,7 +60,6 @@ public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allAr
             SpanLayer spanLayer = TaggingHelper.toLayer(context.getAllKeyValues());
             AbstractSpan abstractSpan = ContextManager.activeSpan();
             abstractSpan
-                .setPeer(SpanHelper.tryToGetPeer(context.getRemoteServiceAddress(), context.getAllKeyValues()))

Review Comment:
   Because it breaks the Test / resttemplate-6.x case on entry span, which expects an empty peer, but the peer from `tryToGetPeer` here will be `/resttemplate-6.x-scenario/resttemplate/syncback` now, it seems meaningless in this case. And now i realize that the peer is required in MQ consumer and producer, but i'm not sure if i should keep this and modify the peer of entry span in Test / resttemplate-6.x case to `/resttemplate-6.x-scenario/resttemplate/syncback`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org