You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2020/03/05 02:17:50 UTC

[kudu-CR] test: re-deflake TabletServerQuiescingITest

Hello Alexey Serbin, Adar Dembo,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/15365

to review the following change.


Change subject: test: re-deflake TabletServerQuiescingITest
......................................................................

test: re-deflake TabletServerQuiescingITest

Commit bc2efa1ae97fcc4e592c93d38592206d48d6f8f5 undid some of the
deflaking done in 6e4dd49 by increasing the number of read threads.

This puts us back at using a single reader, which, while may not always
yield active scanners, should be significantly less flaky.

I ran this 100 times in TSAN mode and saw no failures, compared to the
20% flakiness reported by our test dashboard.

Change-Id: I598c0f0a9a665691bc675920d8dc5a0d272be72e
---
M src/kudu/integration-tests/tablet_server_quiescing-itest.cc
1 file changed, 3 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/15365/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I598c0f0a9a665691bc675920d8dc5a0d272be72e
Gerrit-Change-Number: 15365
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>

[kudu-CR] test: re-deflake TabletServerQuiescingITest

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15365 )

Change subject: test: re-deflake TabletServerQuiescingITest
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I598c0f0a9a665691bc675920d8dc5a0d272be72e
Gerrit-Change-Number: 15365
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 05 Mar 2020 02:34:21 +0000
Gerrit-HasComments: No

[kudu-CR] test: re-deflake TabletServerQuiescingITest

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15365 )

Change subject: test: re-deflake TabletServerQuiescingITest
......................................................................

test: re-deflake TabletServerQuiescingITest

Commit bc2efa1ae97fcc4e592c93d38592206d48d6f8f5 undid some of the
deflaking done in 6e4dd49 by increasing the number of read threads.

This puts us back at using a single reader, which, while may not always
yield active scanners, should be significantly less flaky.

I ran this 100 times in TSAN mode and saw no failures, compared to the
20% flakiness reported by our test dashboard.

Change-Id: I598c0f0a9a665691bc675920d8dc5a0d272be72e
Reviewed-on: http://gerrit.cloudera.org:8080/15365
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/tablet_server_quiescing-itest.cc
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I598c0f0a9a665691bc675920d8dc5a0d272be72e
Gerrit-Change-Number: 15365
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)