You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2012/08/17 22:01:38 UTC

[jira] [Commented] (HADOOP-8710) Remove ability for users to easily run the trash emptier

    [ https://issues.apache.org/jira/browse/HADOOP-8710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437024#comment-13437024 ] 

Hadoop QA commented on HADOOP-8710:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12541405/hadoop-8710.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.ha.TestZKFailoverController

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1326//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1326//console

This message is automatically generated.
                
> Remove ability for users to easily run the trash emptier
> --------------------------------------------------------
>
>                 Key: HADOOP-8710
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8710
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 1.0.0, 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: hadoop-8710.txt
>
>
> Users can currently run the emptier via {{hadoop org.apache.hadoop.fs.Trash}}, which seems error prone as there's nothing in that command that suggests it runs the emptier and nothing that asks you before deleting the trash for all users (that the current user is capable of deleting). Given that the trash emptier runs server side (eg on the NN) let's remove the ability to easily run it client side.  Marking as an incompatible change since someone expecting the hadoop command with this class specified to empty trash will no longer be able to (they'll need to create their own class that does this).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira