You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/01/22 08:03:09 UTC

[GitHub] [apisix-ingress-controller] lianghao208 opened a new pull request #200: chore: add check version script

lianghao208 opened a new pull request #200:
URL: https://github.com/apache/apisix-ingress-controller/pull/200


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bugfix
   - [x] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   - Related issues
   
   #159 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #200: chore: add check version script

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #200:
URL: https://github.com/apache/apisix-ingress-controller/pull/200#issuecomment-765218068


   # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/200?src=pr&el=h1) Report
   > Merging [#200](https://codecov.io/gh/apache/apisix-ingress-controller/pull/200?src=pr&el=desc) (7b4b7a5) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/009db9bcc124398a789fe4aac59d2c74a7264927?el=desc) (009db9b) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/200/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/200?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #200   +/-   ##
   =======================================
     Coverage   47.68%   47.68%           
   =======================================
     Files          32       32           
     Lines        1883     1883           
   =======================================
     Hits          898      898           
     Misses        846      846           
     Partials      139      139           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/200?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/200?src=pr&el=footer). Last update [009db9b...7b4b7a5](https://codecov.io/gh/apache/apisix-ingress-controller/pull/200?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-ingress-controller] lianghao208 commented on pull request #200: chore: add check version script

Posted by GitBox <gi...@apache.org>.
lianghao208 commented on pull request #200:
URL: https://github.com/apache/apisix-ingress-controller/pull/200#issuecomment-765257662


   @gxthrj PTAL, thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-ingress-controller] lianghao208 commented on pull request #200: chore: add check version script

Posted by GitBox <gi...@apache.org>.
lianghao208 commented on pull request #200:
URL: https://github.com/apache/apisix-ingress-controller/pull/200#issuecomment-765337960


   
   > Just make sure the file is assigned executable permissions by default.
   
   @gxthrj Yes, it's assigned executable permissions by default.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-ingress-controller] tokers merged pull request #200: chore: add check version script

Posted by GitBox <gi...@apache.org>.
tokers merged pull request #200:
URL: https://github.com/apache/apisix-ingress-controller/pull/200


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org