You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2016/04/10 08:41:41 UTC
Review Request 45985: Fixed the commit message hook to use `echo -n`
instead.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45985/
-----------------------------------------------------------
Review request for mesos, Joerg Schad, Kevin Klues, and Vinod Kone.
Repository: mesos
Description
-------
See summary.
Diffs
-----
support/hooks/commit-msg d3f10c886a654aa8d8364faddf2e50dc7fe82058
Diff: https://reviews.apache.org/r/45985/diff/
Testing
-------
Thanks,
Michael Park
Re: Review Request 45985: Fixed the commit message hook to use `echo
-n` instead.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45985/#review128512
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On April 10, 2016, 6:43 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45985/
> -----------------------------------------------------------
>
> (Updated April 10, 2016, 6:43 a.m.)
>
>
> Review request for mesos, Joerg Schad, Kevin Klues, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> support/hooks/commit-msg d3f10c886a654aa8d8364faddf2e50dc7fe82058
>
> Diff: https://reviews.apache.org/r/45985/diff/
>
>
> Testing
> -------
>
> Manually tested to confirm that messages of 73 chars are rejected and 72 are accepted.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 45985: Fixed the commit message hook to use `echo
-n` instead.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45985/#review128028
-----------------------------------------------------------
Patch looks great!
Reviews applied: [45984, 45985]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 10, 2016, 6:43 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45985/
> -----------------------------------------------------------
>
> (Updated April 10, 2016, 6:43 a.m.)
>
>
> Review request for mesos, Joerg Schad, Kevin Klues, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> support/hooks/commit-msg d3f10c886a654aa8d8364faddf2e50dc7fe82058
>
> Diff: https://reviews.apache.org/r/45985/diff/
>
>
> Testing
> -------
>
> Manually tested to confirm that messages of 73 chars are rejected and 72 are accepted.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 45985: Fixed the commit message hook to use `echo
-n` instead.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45985/#review128213
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Klues
On April 10, 2016, 6:43 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45985/
> -----------------------------------------------------------
>
> (Updated April 10, 2016, 6:43 a.m.)
>
>
> Review request for mesos, Joerg Schad, Kevin Klues, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> support/hooks/commit-msg d3f10c886a654aa8d8364faddf2e50dc7fe82058
>
> Diff: https://reviews.apache.org/r/45985/diff/
>
>
> Testing
> -------
>
> Manually tested to confirm that messages of 73 chars are rejected and 72 are accepted.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 45985: Fixed the commit message hook to use `echo
-n` instead.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45985/
-----------------------------------------------------------
(Updated April 10, 2016, 6:43 a.m.)
Review request for mesos, Joerg Schad, Kevin Klues, and Vinod Kone.
Repository: mesos
Description
-------
See summary.
Diffs
-----
support/hooks/commit-msg d3f10c886a654aa8d8364faddf2e50dc7fe82058
Diff: https://reviews.apache.org/r/45985/diff/
Testing (updated)
-------
Manually tested to confirm that messages of 73 chars are rejected and 72 are accepted.
Thanks,
Michael Park