[jira] [Commented] (AMBARI-23773) Suppress FindBugs warnings for EclipseLink-generated code

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-23773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465665#comment-16465665 ] 

Hudson commented on AMBARI-23773:
---------------------------------

SUCCESS: Integrated in Jenkins build Ambari-trunk-Commit #9190 (See [https://builds.apache.org/job/Ambari-trunk-Commit/9190/])
AMBARI-23773. Suppress FindBugs warnings for EclipseLink-generated code (github: [https://gitbox.apache.org/repos/asf?p=ambari.git&a=commit&h=ded5af32d569dbb46ed40d50e1d1313a0078b447])
* (edit) ambari-server/pom.xml
* (add) ambari-server/findbugs.exclude.xml


> Suppress FindBugs warnings for EclipseLink-generated code
> ---------------------------------------------------------
>
>                 Key: AMBARI-23773
>                 URL: https://issues.apache.org/jira/browse/AMBARI-23773
>             Project: Ambari
>          Issue Type: Improvement
>          Components: ambari-server
>            Reporter: Doroszlai, Attila
>            Assignee: Doroszlai, Attila
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: trunk
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> FindBugs produces 1428 warnings for String comparisons in Ambari Server's statically weaved entities.  This amounts to almost 400KB in Jenkins build logs.
> {noformat:title=}
> [INFO] Comparison of String parameter using == or != in org.apache.ambari.server.orm.entities.AlertCurrentEntity._persistence_get(String)  [org.apache.ambari.server.orm.entities.AlertCurrentEntity] In AlertCurrentEntity.java ES_COMPARING_PARAMETER_STRING_WITH_EQ
> [INFO] Comparison of String parameter using == or != in org.apache.ambari.server.orm.entities.AlertCurrentEntity._persistence_set(String, Object)  [org.apache.ambari.server.orm.entities.AlertCurrentEntity] In AlertCurrentEntity.java ES_COMPARING_PARAMETER_STRING_WITH_EQ
> {noformat}
> As we have no control over this kind of generated code, it should be suppressed, both to focus on more real problems pointed out by FindBugs, and to reduce size of our build logs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)