[GitHub] [incubator-mxnet] Zha0q1 edited a comment on issue #15210: Custom Operator Profiling Enhancement

[GitBox <gi...@apache.org>]

Zha0q1 edited a comment on issue #15210: Custom Operator Profiling Enhancement
URL: https://github.com/apache/incubator-mxnet/pull/15210#issuecomment-504524827
 
 
   > Lets say an operator got pushed from forward of a custom op but it is an mxnet op. I thought we were going to prepend such ops with custom op name, for example it would say CustomOp1::elemwise_add.
   > Is this skipped currently ?
   
   We have this, it happens in PushAsync in NaiveEngine and ThreadedEngine
   
   > Also, I think the Custom and _backward_custom in the profiling output are very confusing. I think we should remove this from profiling output.
   
   Do you mean the custom and back_custom as we had before? I actually have removed them.
   
   > Also, I see big gaps in the profiling output and I am wondering where it is coming from. I hope it is not the overhead of the profiler itself ? Have you verified this ?
   
   I have compared running the same model with & without my modification, I think the overhead is not large. We could talk about the gap you saw in person

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services