You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by sjcorbett <gi...@git.apache.org> on 2015/07/29 17:58:51 UTC

[GitHub] incubator-brooklyn pull request: Tidy AbstractApplication

GitHub user sjcorbett opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/778

    Tidy AbstractApplication

    * Delete unused fields mgmt, deployed and brooklynProperties.
    * Apply setExpectedState and recordApplicationEvent in tandem.
    * Make recordApplicationEvent accessible from subclasses.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sjcorbett/incubator-brooklyn misc

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/778.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #778
    
----
commit 9cbe341a663248ab7471798ee35e8416b82487b6
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date:   2015-07-29T15:57:30Z

    Tidy AbstractApplication
    
    * Delete unused fields mgmt, deployed and brooklynProperties.
    * Apply setExpectedState and recordApplicationEvent in tandem.
    * Make recordApplicationEvent accessible from subclasses.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Tidy AbstractApplication

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/778


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Tidy AbstractApplication

Posted by sjcorbett <gi...@git.apache.org>.

Github user sjcorbett closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/778


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Tidy AbstractApplication

Posted by bostko <gi...@git.apache.org>.

Github user bostko commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/778#issuecomment-126016545
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Tidy AbstractApplication

Posted by alasdairhodge <gi...@git.apache.org>.

Github user alasdairhodge commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/778#issuecomment-126087179
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Tidy AbstractApplication

Posted by sjcorbett <gi...@git.apache.org>.

GitHub user sjcorbett reopened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/778

    Tidy AbstractApplication

    * Delete unused fields mgmt, deployed and brooklynProperties.
    * Apply setExpectedState and recordApplicationEvent in tandem.
    * Make recordApplicationEvent accessible from subclasses.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sjcorbett/incubator-brooklyn misc

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/778.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #778
    
----
commit 9cbe341a663248ab7471798ee35e8416b82487b6
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date:   2015-07-29T15:57:30Z

    Tidy AbstractApplication
    
    * Delete unused fields mgmt, deployed and brooklynProperties.
    * Apply setExpectedState and recordApplicationEvent in tandem.
    * Make recordApplicationEvent accessible from subclasses.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---