[GitHub] [flink] RyanSkraba commented on a change in pull request #17451: [FLINK-24476][docs] Rename Elasticsearch to remove CamelCase

[GitBox <gi...@apache.org>]

RyanSkraba commented on a change in pull request #17451:
URL: https://github.com/apache/flink/pull/17451#discussion_r728132999



##########
File path: flink-connectors/flink-connector-elasticsearch6/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/table/Elasticsearch6DynamicSink.java
##########
@@ -78,10 +78,10 @@ public Elasticsearch6DynamicSink(
     // on the sink itself.
     // --------------------------------------------------------------
 
-    private final ElasticSearchBuilderProvider builderProvider;
+    private final ElasticsearchBuilderProvider builderProvider;
 
     @FunctionalInterface
-    interface ElasticSearchBuilderProvider {
+    interface ElasticsearchBuilderProvider {

Review comment:
       You are correct, thanks!  I updated the PR description with a **yes** to that question.
   
   A tool like Java API Compliance Checker (JAPICC) would report this as a compatibility issue.  If getting a nice 100% is a priority we can just drop the last commit in this PR, no harm. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org