You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by we...@apache.org on 2019/08/17 00:20:58 UTC

[hadoop] branch trunk updated: HDFS-14523. Remove excess read lock for NetworkToplogy. Contributed by Wu Weiwei.

This is an automated email from the ASF dual-hosted git repository.

weichiu pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/hadoop.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 971a4c8  HDFS-14523. Remove excess read lock for NetworkToplogy. Contributed by Wu Weiwei.
971a4c8 is described below

commit 971a4c8e8328a4bdea65de4a0e84c82b5b2de24b
Author: Wei-Chiu Chuang <we...@apache.org>
AuthorDate: Fri Aug 16 17:19:13 2019 -0700

    HDFS-14523. Remove excess read lock for NetworkToplogy. Contributed by Wu Weiwei.
    
    Signed-off-by: Wei-Chiu Chuang <we...@apache.org>
    Reviewed-by: Chen Liang <cl...@apache.org>
---
 .../main/java/org/apache/hadoop/net/NetworkTopology.java   | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)

diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java
index 6fc4acc..9f608de 100644
--- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java
+++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java
@@ -295,22 +295,12 @@ public class NetworkTopology {
   
   /** @return the total number of racks */
   public int getNumOfRacks() {
-    netlock.readLock().lock();
-    try {
-      return numOfRacks;
-    } finally {
-      netlock.readLock().unlock();
-    }
+    return numOfRacks;
   }
 
   /** @return the total number of leaf nodes */
   public int getNumOfLeaves() {
-    netlock.readLock().lock();
-    try {
-      return clusterMap.getNumOfLeaves();
-    } finally {
-      netlock.readLock().unlock();
-    }
+    return clusterMap.getNumOfLeaves();
   }
 
   /** Return the distance between two nodes


---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org