[GitHub] [incubator-zipkin] adriancole commented on issue #2562: Conditionally wraps in Elasticsearch index template based on version

[GitBox <gi...@apache.org>]

adriancole commented on issue #2562: Conditionally wraps in Elasticsearch index template based on version
URL: https://github.com/apache/incubator-zipkin/pull/2562#issuecomment-489960485
 
 
   verified you can create a secondary index template without the type name now
   
   cc @apache/zipkin-committers as sometimes people ask about this
   
   ```bash
   # start server with elasticsearch 7.0.1 completely wiped out
   # seed our index templates
   $ curl -s localhost:9411/api/v2/traces
   # add a second index template, taking care to do it exactly like we made ours (do not include_type_name=true)
   $ curl -X PUT -v -s localhost:9200/_template/zipkin-span_http.status_code -H'Content-Type: application/json' -d'{
     "index_patterns": [
       "zipkin-span-*"
     ],
     "order": 0,
     "mappings": {
       "properties": {
         "tags.http.status_code": {
           "norms": false,
           "type": "keyword"
         }
       }
     }
   }'
   # make some traffic that has an http 404 (ex brave-webmvc-example)
   $ curl -s localhost:8081/bobby
   # verify the index
   $ curl -s 'localhost:9200/zipkin-span-*/_search?q=tags.http.status_code:404'
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services