You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "snuyanzin (via GitHub)" <gi...@apache.org> on 2024/11/30 16:04:17 UTC
[PR] [FLINK-36822][build] Enable spotless for java 21 [flink]
snuyanzin opened a new pull request, #25714:
URL: https://github.com/apache/flink/pull/25714
## What is the purpose of the change
Since minimum java version was bumped to 11 at https://github.com/apache/flink/commit/50716d6ad8008c6080e9211d212f8c948dd8b614
we could also bump spotless and googleformat to be able to enable it for java 21
## Brief change log
pom.xml
applying `./mvnw spotless:apply`
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes )
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes )
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): ( no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no)
- The S3 file system connector: ( no)
## Documentation
- Does this pull request introduce a new feature? ( no)
- If yes, how is the feature documented? (not applicable )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36822][build] Enable spotless for java 21 [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #25714:
URL: https://github.com/apache/flink/pull/25714#discussion_r1864308061
##########
pom.xml:
##########
@@ -2154,7 +2144,7 @@ under the License.
<skip>${spotless.skip}</skip>
<java>
<googleJavaFormat>
- <version>1.7</version>
+ <version>1.24.0</version>
Review Comment:
The latest version still supporting java 11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36822][build] Enable spotless for java 21 [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #25714:
URL: https://github.com/apache/flink/pull/25714#issuecomment-2509019863
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5f54dc56d4064f7eb68a48376977f6d858fba26",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a5f54dc56d4064f7eb68a48376977f6d858fba26",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a5f54dc56d4064f7eb68a48376977f6d858fba26 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36822][build] Enable spotless for java 21 [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #25714:
URL: https://github.com/apache/flink/pull/25714#discussion_r1869646161
##########
pom.xml:
##########
@@ -177,7 +177,7 @@ under the License.
<checkstyle.version>10.18.2</checkstyle.version>
<!-- can be removed with maven-spotless-plugin:2.38+ -->
Review Comment:
can we remove this comment and the line below now we are 2.38+
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36822][build] Enable spotless for java 21 [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on PR #25714:
URL: https://github.com/apache/flink/pull/25714#issuecomment-2519639493
Reviewed by Chi on 05/12/24 Need a committer to review. @rmetzger was curious why we were on such a low level of spotless and thought there might have been a reason we stayed back level. We assume that losing java 8 and support for 21 is the reason why this level is now appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36822][build] Enable spotless for java 21 [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin merged PR #25714:
URL: https://github.com/apache/flink/pull/25714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36822][build] Enable spotless for java 21 [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #25714:
URL: https://github.com/apache/flink/pull/25714#discussion_r1864307637
##########
pom.xml:
##########
@@ -2154,7 +2144,7 @@ under the License.
<skip>${spotless.skip}</skip>
<java>
<googleJavaFormat>
- <version>1.7</version>
+ <version>1.17.0</version>
Review Comment:
The latest version still supporting java 11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36822][build] Enable spotless for java 21 [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #25714:
URL: https://github.com/apache/flink/pull/25714#discussion_r1864307637
##########
pom.xml:
##########
@@ -2154,7 +2144,7 @@ under the License.
<skip>${spotless.skip}</skip>
<java>
<googleJavaFormat>
- <version>1.7</version>
+ <version>1.17.0</version>
Review Comment:
The latest version still supporting java 11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36822][build] Enable spotless for java 21 [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #25714:
URL: https://github.com/apache/flink/pull/25714#discussion_r1869646161
##########
pom.xml:
##########
@@ -177,7 +177,7 @@ under the License.
<checkstyle.version>10.18.2</checkstyle.version>
<!-- can be removed with maven-spotless-plugin:2.38+ -->
Review Comment:
can we remove this comment and potentially the line below now we are 2.38+
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36822][build] Enable spotless for java 21 [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #25714:
URL: https://github.com/apache/flink/pull/25714#discussion_r1870394479
##########
pom.xml:
##########
@@ -177,7 +177,7 @@ under the License.
<checkstyle.version>10.18.2</checkstyle.version>
<!-- can be removed with maven-spotless-plugin:2.38+ -->
Review Comment:
removed.
>can we remove this comment now we are 2.38+ . Is there anything to action? I assume we can still skip spotless at 2.38+. Otherwise we should add this asap to minimize merge issues for open PRs.
Didn't get your comment.
The reason it was skipped for lower than 2.38 is the fact that spotless with those version didn't support java 21.
Regarding merge issues: I wouldn't expect lots of conflicts since changes are related to some weird situations (you can find them in changeset)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36822][build] Enable spotless for java 21 [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #25714:
URL: https://github.com/apache/flink/pull/25714#discussion_r1869646161
##########
pom.xml:
##########
@@ -177,7 +177,7 @@ under the License.
<checkstyle.version>10.18.2</checkstyle.version>
<!-- can be removed with maven-spotless-plugin:2.38+ -->
Review Comment:
can we remove this comment now we are 2.38+ . Is there anything to action? I assume we can still skip spotless at 2.38+
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36822][build] Enable spotless for java 21 [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #25714:
URL: https://github.com/apache/flink/pull/25714#issuecomment-2519452414
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36822][build] Enable spotless for java 21 [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #25714:
URL: https://github.com/apache/flink/pull/25714#discussion_r1864307453
##########
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClientConfiguration.java:
##########
@@ -57,17 +57,23 @@ public RestClientConfiguration getRestClientConfiguration() {
return restClientConfiguration;
}
- /** @see RestOptions#AWAIT_LEADER_TIMEOUT */
+ /**
+ * @see RestOptions#AWAIT_LEADER_TIMEOUT
+ */
Review Comment:
All changes in java files is a result of
```
./mvnw spotless:apply
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36822][build] Enable spotless for java 21 [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #25714:
URL: https://github.com/apache/flink/pull/25714#discussion_r1869646161
##########
pom.xml:
##########
@@ -177,7 +177,7 @@ under the License.
<checkstyle.version>10.18.2</checkstyle.version>
<!-- can be removed with maven-spotless-plugin:2.38+ -->
Review Comment:
can we remove this comment now we are 2.38+ . Is there anything to action? I assume we can still skip spotless at 2.38+. Otherwise we should add this asap to minimize merge issues for open PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36822][build] Enable spotless for java 21 [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #25714:
URL: https://github.com/apache/flink/pull/25714#discussion_r1870920837
##########
pom.xml:
##########
@@ -177,7 +177,7 @@ under the License.
<checkstyle.version>10.18.2</checkstyle.version>
<!-- can be removed with maven-spotless-plugin:2.38+ -->
Review Comment:
thanks for the reassurance @snuyanzin that there should be a low change of merge conflicts - I had not looked at the effected files in detail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org