You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hawq.apache.org by shivzone <gi...@git.apache.org> on 2017/10/04 00:23:05 UTC

[GitHub] incubator-hawq pull request #1295: HAWQ-1535. PXF make install should also g...

GitHub user shivzone opened a pull request:

    https://github.com/apache/incubator-hawq/pull/1295

    HAWQ-1535. PXF make install should also generate non versioned jars

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shivzone/incubator-hawq HAWQ-1535

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hawq/pull/1295.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1295
    
----
commit 0668e2bd754ad4eefa0f07ac3303745e7c011889
Author: shivzone <sh...@gmail.com>
Date:   2017-10-04T00:17:10Z

    HAWQ-1535. PXF make install should also generate non versioned jars

----


---

[GitHub] incubator-hawq pull request #1295: HAWQ-1535. PXF make install should also g...

Posted by shivzone <gi...@git.apache.org>.

Github user shivzone closed the pull request at:

    https://github.com/apache/incubator-hawq/pull/1295


---

[GitHub] incubator-hawq pull request #1295: HAWQ-1535. PXF make install should also g...

Posted by sansanichfb <gi...@git.apache.org>.

Github user sansanichfb commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1295#discussion_r143069444
  
    --- Diff: pxf/pxf-service/src/configs/templates/pxf-private.classpath.template ---
    @@ -23,16 +23,15 @@
     PXF_HOME/conf
     
     # PXF Libraries
    -PXF_HOME/lib/pxf-hbase-*[0-9].jar
    -PXF_HOME/lib/pxf-hdfs-*[0-9].jar
    -PXF_HOME/lib/pxf-hive-*[0-9].jar
    -PXF_HOME/lib/pxf-json-*[0-9].jar
    -PXF_HOME/lib/pxf-jdbc-*[0-9].jar
    +PXF_HOME/lib/pxf-hbase.jar
    +PXF_HOME/lib/pxf-hdfs.jar
    +PXF_HOME/lib/pxf-hive.jar
    +PXF_HOME/lib/pxf-json.jar
    +PXF_HOME/lib/pxf-jdbc.jar
     
    -# Hadoop/Hive/HBase configurations
    +# Hadoop/Hive configurations
     HADOOP_HOME/etc/hadoop
     HIVE_HOME/conf
    -HBASE_HOME/conf
    --- End diff --
    
    Why are we removing HBase entries?


---