You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2015/08/28 13:32:23 UTC

Review Request 37887: SQLA: Fix sudo(rights and owner) for oozie and hive in scope of jdbc

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37887/
-----------------------------------------------------------

Review request for Ambari, Jayush Luniya and Myroslav Papirkovskyy.


Bugs: AMBARI-12914
    https://issues.apache.org/jira/browse/AMBARI-12914


Repository: ambari


Description
-------

Need to fix rights and owner of jdbc driver and native libraries, for sudo functionality, in hive and oozie.


Diffs
-----

  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 3bb8f4d 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py b955b12 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 5fd531a 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 47dffec 
  ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 525963d 
  ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py fe5a2b5 

Diff: https://reviews.apache.org/r/37887/diff/


Testing
-------

mvn clean test


Thanks,

Vitalyi Brodetskyi


Re: Review Request 37887: SQLA: Fix sudo(rights and owner) for oozie and hive in scope of jdbc

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37887/#review97080
-----------------------------------------------------------

Ship it!


Ship It!

- Vitalyi Brodetskyi


On Сер. 29, 2015, 10:48 до полудня, Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37887/
> -----------------------------------------------------------
> 
> (Updated Сер. 29, 2015, 10:48 до полудня)
> 
> 
> Review request for Ambari, Jayush Luniya and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-12914
>     https://issues.apache.org/jira/browse/AMBARI-12914
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Need to fix rights and owner of jdbc driver and native libraries, for sudo functionality, in hive and oozie.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py f10cca1 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py b955b12 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 3e90eb5 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 525963d 
>   ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py fe5a2b5 
> 
> Diff: https://reviews.apache.org/r/37887/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 37887: SQLA: Fix sudo(rights and owner) for oozie and hive in scope of jdbc

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37887/#review97078
-----------------------------------------------------------

Ship it!


Ship It!

- Jayush Luniya


On Aug. 29, 2015, 10:48 a.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37887/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2015, 10:48 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-12914
>     https://issues.apache.org/jira/browse/AMBARI-12914
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Need to fix rights and owner of jdbc driver and native libraries, for sudo functionality, in hive and oozie.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py f10cca1 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py b955b12 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 3e90eb5 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 525963d 
>   ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py fe5a2b5 
> 
> Diff: https://reviews.apache.org/r/37887/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 37887: SQLA: Fix sudo(rights and owner) for oozie and hive in scope of jdbc

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37887/
-----------------------------------------------------------

(Updated Сер. 29, 2015, 10:48 до полудня)


Review request for Ambari, Jayush Luniya and Myroslav Papirkovskyy.


Bugs: AMBARI-12914
    https://issues.apache.org/jira/browse/AMBARI-12914


Repository: ambari


Description
-------

Need to fix rights and owner of jdbc driver and native libraries, for sudo functionality, in hive and oozie.


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py f10cca1 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py b955b12 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 3e90eb5 
  ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 525963d 
  ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py fe5a2b5 

Diff: https://reviews.apache.org/r/37887/diff/


Testing
-------

mvn clean test


Thanks,

Vitalyi Brodetskyi


Re: Review Request 37887: SQLA: Fix sudo(rights and owner) for oozie and hive in scope of jdbc

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.

> On Сер. 28, 2015, 4:26 після полудня, Jayush Luniya wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml, line 59
> > <https://reviews.apache.org/r/37887/diff/1/?file=1057787#file1057787line59>
> >
> >     Why do we need this change to repo_suse_rhel_template? Remnant of testing?

Sorry, forgot to remove it after testing.


> On Сер. 28, 2015, 4:26 після полудня, Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py, line 383
> > <https://reviews.apache.org/r/37887/diff/1/?file=1057784#file1057784line383>
> >
> >     Do we also need to update permissions and ownership (chmod/chown)?

We are using it only in hive, and owner has all needed users...so no need for chmod.


- Vitalyi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37887/#review96877
-----------------------------------------------------------


On Сер. 29, 2015, 10:48 до полудня, Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37887/
> -----------------------------------------------------------
> 
> (Updated Сер. 29, 2015, 10:48 до полудня)
> 
> 
> Review request for Ambari, Jayush Luniya and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-12914
>     https://issues.apache.org/jira/browse/AMBARI-12914
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Need to fix rights and owner of jdbc driver and native libraries, for sudo functionality, in hive and oozie.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py f10cca1 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py b955b12 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 3e90eb5 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 525963d 
>   ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py fe5a2b5 
> 
> Diff: https://reviews.apache.org/r/37887/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 37887: SQLA: Fix sudo(rights and owner) for oozie and hive in scope of jdbc

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.

> On Сер. 28, 2015, 4:26 після полудня, Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py, line 383
> > <https://reviews.apache.org/r/37887/diff/1/?file=1057784#file1057784line383>
> >
> >     Do we also need to update permissions and ownership (chmod/chown)?
> 
> Vitalyi Brodetskyi wrote:
>     We are using it only in hive, and owner has all needed users...so no need for chmod.

*users -> *permissions
Talked with Andrew O, author of non root...he agreed with this solution


- Vitalyi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37887/#review96877
-----------------------------------------------------------


On Сер. 29, 2015, 10:48 до полудня, Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37887/
> -----------------------------------------------------------
> 
> (Updated Сер. 29, 2015, 10:48 до полудня)
> 
> 
> Review request for Ambari, Jayush Luniya and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-12914
>     https://issues.apache.org/jira/browse/AMBARI-12914
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Need to fix rights and owner of jdbc driver and native libraries, for sudo functionality, in hive and oozie.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py f10cca1 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py b955b12 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 3e90eb5 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 525963d 
>   ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py fe5a2b5 
> 
> Diff: https://reviews.apache.org/r/37887/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 37887: SQLA: Fix sudo(rights and owner) for oozie and hive in scope of jdbc

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37887/#review96877
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py (line 383)
<https://reviews.apache.org/r/37887/#comment152567>

    Do we also need to update permissions and ownership (chmod/chown)?



ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml (line 59)
<https://reviews.apache.org/r/37887/#comment152565>

    Why do we need this change to repo_suse_rhel_template? Remnant of testing?


- Jayush Luniya


On Aug. 28, 2015, 11:32 a.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37887/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2015, 11:32 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-12914
>     https://issues.apache.org/jira/browse/AMBARI-12914
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Need to fix rights and owner of jdbc driver and native libraries, for sudo functionality, in hive and oozie.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 3bb8f4d 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py b955b12 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 5fd531a 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 47dffec 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 525963d 
>   ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py fe5a2b5 
> 
> Diff: https://reviews.apache.org/r/37887/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>