You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "xzj7019 (via GitHub)" <gi...@apache.org> on 2023/06/14 06:38:42 UTC
[GitHub] [doris] xzj7019 opened a new pull request, #20789: [improvement](nereids) prune hash join output slot ids list
xzj7019 opened a new pull request, #20789:
URL: https://github.com/apache/doris/pull/20789
## Proposed changes
Issue Number: close #xxx
1. prune hash join output slot ids list based on slot ids in required project and other conjunctions, to reduce the be side effort.
2. support pruning for semi/anti also
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xzj7019 commented on pull request #20789: [improvement](nereids) prune hash join output slot ids list
Posted by "xzj7019 (via GitHub)" <gi...@apache.org>.
xzj7019 commented on PR #20789:
URL: https://github.com/apache/doris/pull/20789#issuecomment-1610936676
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xzj7019 commented on pull request #20789: [improvement](nereids) prune hash join output slot ids list
Posted by "xzj7019 (via GitHub)" <gi...@apache.org>.
xzj7019 commented on PR #20789:
URL: https://github.com/apache/doris/pull/20789#issuecomment-1590563826
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #20789: [improvement](nereids) prune hash join output slot ids list
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #20789:
URL: https://github.com/apache/doris/pull/20789#issuecomment-1610990963
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 42.19 seconds
stream load tsv: 468 seconds loaded 74807831229 Bytes, about 152 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 69.5 seconds inserted 10000000 Rows, about 143K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230628082921_clickbench_pr_169191.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20789: [improvement](nereids) prune hash join output slot ids list
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20789:
URL: https://github.com/apache/doris/pull/20789#issuecomment-1611062923
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xzj7019 commented on pull request #20789: [improvement](nereids) prune hash join output slot ids list
Posted by "xzj7019 (via GitHub)" <gi...@apache.org>.
xzj7019 commented on PR #20789:
URL: https://github.com/apache/doris/pull/20789#issuecomment-1609332747
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xzj7019 commented on pull request #20789: [improvement](nereids) prune hash join output slot ids list
Posted by "xzj7019 (via GitHub)" <gi...@apache.org>.
xzj7019 commented on PR #20789:
URL: https://github.com/apache/doris/pull/20789#issuecomment-1609134393
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xzj7019 commented on pull request #20789: [improvement](nereids) prune hash join output slot ids list
Posted by "xzj7019 (via GitHub)" <gi...@apache.org>.
xzj7019 commented on PR #20789:
URL: https://github.com/apache/doris/pull/20789#issuecomment-1593126004
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly commented on a diff in pull request #20789: [improvement](nereids) prune hash join output slot ids list
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on code in PR #20789:
URL: https://github.com/apache/doris/pull/20789#discussion_r1244578302
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java:
##########
@@ -1691,17 +1717,26 @@ public PlanFragment visitPhysicalProject(PhysicalProject<? extends Plan> project
JoinNodeBase hashJoinNode = (JoinNodeBase) inputPlanNode;
hashJoinNode.setvOutputTupleDesc(tupleDescriptor);
hashJoinNode.setvSrcToOutputSMap(execExprList);
+ // prune the hashOutputSlotIds
+ if (hashJoinNode instanceof HashJoinNode) {
Review Comment:
Nest loop join also need this prune.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xzj7019 commented on pull request #20789: [improvement](nereids) prune hash join output slot ids list
Posted by "xzj7019 (via GitHub)" <gi...@apache.org>.
xzj7019 commented on PR #20789:
URL: https://github.com/apache/doris/pull/20789#issuecomment-1592927535
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xzj7019 commented on pull request #20789: [improvement](nereids) prune hash join output slot ids list
Posted by "xzj7019 (via GitHub)" <gi...@apache.org>.
xzj7019 commented on PR #20789:
URL: https://github.com/apache/doris/pull/20789#issuecomment-1607411317
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xzj7019 commented on pull request #20789: [improvement](nereids) prune hash join output slot ids list
Posted by "xzj7019 (via GitHub)" <gi...@apache.org>.
xzj7019 commented on PR #20789:
URL: https://github.com/apache/doris/pull/20789#issuecomment-1606419573
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly merged pull request #20789: [improvement](nereids) prune hash join output slot ids list
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly merged PR #20789:
URL: https://github.com/apache/doris/pull/20789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xzj7019 commented on a diff in pull request #20789: [improvement](nereids) prune hash join output slot ids list
Posted by "xzj7019 (via GitHub)" <gi...@apache.org>.
xzj7019 commented on code in PR #20789:
URL: https://github.com/apache/doris/pull/20789#discussion_r1244581189
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java:
##########
@@ -1691,17 +1717,26 @@ public PlanFragment visitPhysicalProject(PhysicalProject<? extends Plan> project
JoinNodeBase hashJoinNode = (JoinNodeBase) inputPlanNode;
hashJoinNode.setvOutputTupleDesc(tupleDescriptor);
hashJoinNode.setvSrcToOutputSMap(execExprList);
+ // prune the hashOutputSlotIds
+ if (hashJoinNode instanceof HashJoinNode) {
Review Comment:
hash is sensitive, leave nlj for later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20789: [improvement](nereids) prune hash join output slot ids list
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20789:
URL: https://github.com/apache/doris/pull/20789#issuecomment-1611062861
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xzj7019 commented on pull request #20789: [improvement](nereids) prune hash join output slot ids list
Posted by "xzj7019 (via GitHub)" <gi...@apache.org>.
xzj7019 commented on PR #20789:
URL: https://github.com/apache/doris/pull/20789#issuecomment-1593206571
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org