[GitHub] [hive] abstractdog commented on a diff in pull request #4085: HIVE-15826: Add 'serialization.encoding' To All SerDes

["abstractdog (via GitHub)" <gi...@apache.org>]

abstractdog commented on code in PR #4085:
URL: https://github.com/apache/hive/pull/4085#discussion_r1121778864


##########
ql/src/test/queries/clientpositive/serde_opencsv.q:
##########
@@ -28,9 +29,10 @@ ROW FORMAT SERDE 'org.apache.hadoop.hive.serde2.OpenCSVSerde'
 WITH SERDEPROPERTIES(
   "separatorChar" = ",",
   "quoteChar"     = "\'",
-  "escapeChar"    = "\\"
+  "escapeChar"    = "\\",
+  "serialization.encoding" = "ISO8859_1"
 ) stored as textfile;
 
 LOAD DATA LOCAL INPATH "../../data/files/opencsv-data.txt" INTO TABLE serde_opencsv;
 
-SELECT count(*) FROM serde_opencsv;
+SELECT * FROM serde_opencsv;

Review Comment:
   was there any purpose of the original count(*) query? without knowing the history, I believe we can leave both queries here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org