[jira] Commented: (HBASE-1595) hadoop-default.xml and zoo.cfg in hbase jar

["stack (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725840#action_12725840 ] 

stack commented on HBASE-1595:
------------------------------

Committing the below which also changes the default Driver for hbase.jar from mapred to mapreduce:

{code}
durruti:cleantrunk stack$ svn diff build.xml
Index: build.xml
===================================================================
--- build.xml   (revision 789834)
+++ build.xml   (working copy)
@@ -182,10 +182,13 @@
       </fileset>
     </copy>
     <jar jarfile="${jarfile}" basedir="${build.classes}" >
+      <fileset dir="${conf.dir}" >
+        <include name="hbase-default.xml" />
+      </fileset>
       <zipfileset dir="conf" prefix="conf" includes="zoo.cfg,hbase-default.xml" />
       <zipfileset dir="${build.webapps}" prefix="webapps"/>
                <manifest>
-            <attribute name="Main-Class" value="org/apache/hadoop/hbase/mapred/Driver" />
+            <attribute name="Main-Class" value="org/apache/hadoop/hbase/mapreduce/Driver" />
        </manifest>
     </jar>
   </target>
{code}

> hadoop-default.xml and zoo.cfg in hbase jar
> -------------------------------------------
>
>                 Key: HBASE-1595
>                 URL: https://issues.apache.org/jira/browse/HBASE-1595
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>             Fix For: 0.20.0
>
>
> A while back I'd added zoo.cfg to the hbase jar.  I added it at top-level.  Turns out that was wrong location.   It couldn't be found unless it was in a conf subdir.  Fellas trying to build unit tests that depended on hbase were getting this:
> {code}
> 21:31 < cwensel> adding zoo.cfg to cp gets me this: junit.framework.AssertionFailedError: Forked Java VM exited abnormally. Please note the time in the report does not reflect the time until the VM exit.
> {code}
> So, I moved zoo.cfg down into conf but also moved hbase-default.xml there.  The latter was a mistake.  It should stay at top level.  In its new location, fellas were getting NPEs out of ZK Quorum Main.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.