You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by blrunner <gi...@git.apache.org> on 2015/09/07 05:37:40 UTC
[GitHub] tajo pull request: TAJO-1739: Add a statement for adding partition...
GitHub user blrunner opened a pull request:
https://github.com/apache/tajo/pull/734
TAJO-1739: Add a statement for adding partition to TajoDump
Add a statement for adding partition to TajoDump
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/blrunner/tajo TAJO-1739
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/734.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #734
----
commit 6c0df4cf01f86f97da3a0a6d86fe3a9535db5fe1
Author: JaeHwa Jung <bl...@apache.org>
Date: 2015-09-07T03:36:27Z
TAJO-1739: Add a statement for adding partition to TajoDump
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1739: Add a statement for adding partition...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/734#discussion_r39046798
--- Diff: tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto ---
@@ -407,3 +407,8 @@ message IndexResponse {
required ReturnState state = 1;
optional IndexDescProto indexDesc = 2;
}
+
+message GetPartitionsResponse {
--- End diff --
You seem to move this message to here to use in TajoMasterClientProtocol. If so, rename it like other messages.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1739: Add a statement for adding partition...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/734
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1739: Add a statement for adding partition...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/734#discussion_r39045642
--- Diff: tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto ---
@@ -407,3 +407,8 @@ message IndexResponse {
required ReturnState state = 1;
optional IndexDescProto indexDesc = 2;
}
+
+message GetPartitionsResponse {
--- End diff --
Every message for rpc communication with catalog should locate in CatalogProtocol.proto.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1739: Add a statement for adding partition...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/734#issuecomment-139110232
@jihoonson
I reflected your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1739: Add a statement for adding partition...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/734#issuecomment-139427882
+1 looks good to me!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1739: Add a statement for adding partition...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/734#discussion_r39047174
--- Diff: tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClientImpl.java ---
@@ -241,6 +241,22 @@ public TableDesc getTableDesc(final String tableName) throws UndefinedTableExcep
}
@Override
+ public List<PartitionDescProto> getAllPartitions(final String tableName) {
+ final BlockingInterface stub = conn.getTMStub();
+
+ GetPartitionsResponse response;
+ try {
+ response = stub.getPartitionsByTableName(null,
+ conn.getSessionedString(tableName));
+ } catch (ServiceException e) {
+ throw new RuntimeException(e);
+ }
+
+ ensureOk(response.getState());
--- End diff --
```UndefinedTableException``` and ```UndefinedDatabaseException``` must be handled.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1739: Add a statement for adding partition...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/734#issuecomment-139436784
Thanks @jihoonson
I'll ship it. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1739: Add a statement for adding partition...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/734#issuecomment-139258017
I missed that AbstractDBStore.getPartitions() already throws UndefinedTableException and UndefinedDatabaseException properly. Sorry for the last comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---