You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by nologic <gi...@git.apache.org> on 2018/01/22 05:40:24 UTC
[GitHub] nifi pull request #2420: NIFI-4731
GitHub user nologic opened a pull request:
https://github.com/apache/nifi/pull/2420
NIFI-4731
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nologic/nifi NIFI-4731
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2420.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2420
----
commit 58d69b6ff04b57e6f59e6eb9581fb07a64687b54
Author: Mikhail Sosonkin <mi...@...>
Date: 2018-01-13T01:51:50Z
bq processors
commit 3a4749a7b467fff0188174bc256e53818d43b7ba
Author: Mikhail Sosonkin <mi...@...>
Date: 2018-01-13T03:19:28Z
initial tests
commit 455ecbc8e1f8469a665ec95dfe04bb87d7743492
Author: Mikhail Sosonkin <mi...@...>
Date: 2018-01-15T23:01:15Z
one test complete
commit ee140a13026de68a010527fc5014802b278e50ea
Author: Mikhail Sosonkin <mi...@...>
Date: 2018-01-15T23:08:35Z
clean up attributes
commit b6a02cd3558d33cb3f23847c94665a1830cb3d68
Author: Mikhail Sosonkin <mi...@...>
Date: 2018-01-19T01:19:44Z
batch test
commit 06304c33c030bbe36fad2cdb398897e8475852dd
Author: Mikhail Sosonkin <mi...@...>
Date: 2018-01-22T05:05:43Z
Merge branch 'master' of github.com:nologic/nifi into NIFI-4731
----
---
[GitHub] nifi issue #2420: NIFI-4731
Posted by nologic <gi...@git.apache.org>.
Github user nologic commented on the issue:
https://github.com/apache/nifi/pull/2420
cool, all checks have passed. Is there anything else you need need before this thing gets scheduled for a merge?
---
[GitHub] nifi issue #2420: NIFI-4731
Posted by danieljimenez <gi...@git.apache.org>.
Github user danieljimenez commented on the issue:
https://github.com/apache/nifi/pull/2420
There are two other PRs that supersede this one.
---
[GitHub] nifi issue #2420: NIFI-4731
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2420
please address the author tags.
On Feb 22, 2018 8:57 PM, "nologic" <no...@github.com> wrote:
> cool, all checks have passed. Is there anything else you need need before
> this thing gets scheduled for a merge?
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/nifi/pull/2420#issuecomment-367885592>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AC6nOdgDT28RR1dAG6wlW1JtVdt5ww5Lks5tXhsEgaJpZM4RmMHW>
> .
>
---
[GitHub] nifi issue #2420: NIFI-4731
Posted by nologic <gi...@git.apache.org>.
Github user nologic commented on the issue:
https://github.com/apache/nifi/pull/2420
@MikeThomsen seems like a lot of violations, what's the best way to clear these up?
---
[GitHub] nifi issue #2420: NIFI-4731
Posted by lsh-0 <gi...@git.apache.org>.
Github user lsh-0 commented on the issue:
https://github.com/apache/nifi/pull/2420
hi guys - I've just introduced NiFi at work, [found and built this](https://github.com/sand0id/nifi-bigquery-bundle), discovered it's many limitations and was about to rewrite it when I found this ticket!
May I ask what is currently blocking it?
---
[GitHub] nifi issue #2420: NIFI-4731
Posted by MikeThomsen <gi...@git.apache.org>.
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2420
> May I ask what is currently blocking it?
@nologic appears to have not addressed all of the review feedback.
@joewitt I can rebase and address the author tags. If the tests run, I can merge myself. You want to do that?
---
[GitHub] nifi pull request #2420: NIFI-4731
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2420
---
[GitHub] nifi issue #2420: NIFI-4731
Posted by MikeThomsen <gi...@git.apache.org>.
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2420
@nologic Log said you have 164 checkstyle violations in nifi-gcp-processors.
---
[GitHub] nifi issue #2420: NIFI-4731
Posted by lsh-0 <gi...@git.apache.org>.
Github user lsh-0 commented on the issue:
https://github.com/apache/nifi/pull/2420
I've just taken a look at the other two tickets and it looks like #3019 is the most recent one but is lacking the conversation/ticket history. As an outsider I can see that's three open tickets for one feature with a chain like #2420 -> #2682 -> #3019 .
I think at the very least this ticket (#2420) can be closed as it's quite definitely superceded.
---
[GitHub] nifi issue #2420: NIFI-4731
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2420
It is 164 violations but all very easy things to fix. It is possible there was some newline issues in generating the PR or just some IDE formatting thing can be run. But it should be super easy to fixup
---
[GitHub] nifi issue #2420: NIFI-4731
Posted by MikeThomsen <gi...@git.apache.org>.
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2420
It's whack-a-mole. To see many/all of them at once do this from the source root:
`mvn clean install -Pcontrib-check :nifi-gcp-processors`
(I didn't look closely. I'm assuming `nifi-gcp-processors` was the maven module that was failing. It needs to be the failing maven module's maven name + `:` at the start to tell Maven to only build that one module w/ the full contrib-check profile)
Then you just keep changing until you make stylecheck happy.
---