You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "ottoka (via GitHub)" <gi...@apache.org> on 2023/02/27 08:46:24 UTC
[GitHub] [james-project] ottoka opened a new pull request, #1468: JAMES-3890 Allow parallel execution of safe tasks (3.7.x backport)
ottoka opened a new pull request, #1468:
URL: https://github.com/apache/james-project/pull/1468
This is a backport of #1452 to the 3.7.x branch. In order to keep it minimal, there are some notable changes compared to the master version:
- Task.runAsync() uses Schedulers.elastic() since ReactorUtils.BLOCKING_CALL_WRAPPER has not been introduced yet.
- SerialTaskManagerWorker.close() does not cancel and wait for tasks to finish. Seems that was introduced later an never backported. While I could add this as a potential stability improvement, I am not sure what the impact would be.
- There is no ExpireMailboxTask yet to use as a showcase, though I did a smoke test with a private extension that was its spiritual predecessor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] ottoka commented on pull request #1468: JAMES-3890 Allow parallel execution of safe tasks (3.7.x backport)
Posted by "ottoka (via GitHub)" <gi...@apache.org>.
ottoka commented on PR #1468:
URL: https://github.com/apache/james-project/pull/1468#issuecomment-1446011168
I originally thought it would make sense, but now that you mention it... No, it is not strictly necessary right now, it would only be a preparation for the future, in case we need to backport something else that relies on async task management.
But if you would prefer to keep changes on the 3.7.x branch to a minimum, I am OK with dropping this backport and just keep the repo for future reference just in case, until there is a 3.8.0 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on pull request #1468: JAMES-3890 Allow parallel execution of safe tasks (3.7.x backport)
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #1468:
URL: https://github.com/apache/james-project/pull/1468#issuecomment-1445982362
Is it really necessary to backport this to 3.7.x though?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] ottoka merged pull request #1468: JAMES-3890 Allow parallel execution of safe tasks (3.7.x backport)
Posted by "ottoka (via GitHub)" <gi...@apache.org>.
ottoka merged PR #1468:
URL: https://github.com/apache/james-project/pull/1468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] ottoka commented on pull request #1468: JAMES-3890 Allow parallel execution of safe tasks (3.7.x backport)
Posted by "ottoka (via GitHub)" <gi...@apache.org>.
ottoka commented on PR #1468:
URL: https://github.com/apache/james-project/pull/1468#issuecomment-1446070600
Well, I can use it to improve the operations of my predecessor to ExpireMailboxTask, so I would like to include it.
@Arsnael : Unless you have a strong objection?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org