You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <bl...@incubator.apache.org> on 2013/01/09 18:00:37 UTC
[Apache Bloodhound] #347: Include sumbit button for comments ,
lost after #345
#347: Include sumbit button for comments , lost after #345
------------------------+------------------------
Reporter: olemis | Owner: nobody
Type: enhancement | Status: new
Priority: major | Component: ui design
Version: | Resolution:
------------------------+------------------------
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/347>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #347: Include sumbit button for comments ,
lost after #345
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#347: Include sumbit button for comments , lost after #345
--------------------------+------------------------------------
Reporter: olemis | Owner: olemis
Type: enhancement | Status: closed
Priority: critical | Milestone: Release 4
Component: ui design | Version:
Resolution: fixed | Keywords: ticket web_ui comments
--------------------------+------------------------------------
Changes (by gjm):
* status: assigned => closed
* resolution: => fixed
Comment:
r1431144 fixes.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/347#comment:7>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #347: Include sumbit button for comments ,
lost after #345
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#347: Include sumbit button for comments , lost after #345
--------------------------+------------------------------------
Reporter: olemis | Owner: olemis
Type: enhancement | Status: assigned
Priority: critical | Milestone: Release 4
Component: ui design | Version:
Resolution: | Keywords: ticket web_ui comments
--------------------------+------------------------------------
Comment (by gjm):
It looks like it works. To be on the safe side I will also include
{{{$('#propertyform .buttons [name="preview"]').hide();}}} to stop users
from getting a page reload and thus accidentally losing any ticket
property edits.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/347#comment:6>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #347: Include sumbit button for comments ,
lost after #345
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#347: Include sumbit button for comments , lost after #345
--------------------------+------------------------------------
Reporter: olemis | Owner: olemis
Type: enhancement | Status: assigned
Priority: critical | Milestone: Release 4
Component: ui design | Version:
Resolution: | Keywords: ticket web_ui comments
--------------------------+------------------------------------
Comment (by olemis):
Replying to [comment:3 gjm]:
> reviewing the problem, I don't think #345 is quite good enough without
this. For a start, it looks like you have to put the ticket into the edit
state to be able to submit the ticket.
>
> A possible fix for that might be something like:
>
... if it works (afaics it should ;) I'm ok with it .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/347#comment:5>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #347: Include sumbit button for comments ,
lost after #345
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#347: Include sumbit button for comments , lost after #345
--------------------------+------------------------------------
Reporter: olemis | Owner: olemis
Type: enhancement | Status: assigned
Priority: major | Milestone:
Component: ui design | Version:
Resolution: | Keywords: ticket web_ui comments
--------------------------+------------------------------------
Changes (by olemis):
* status: new => assigned
* keywords: => ticket web_ui comments
* owner: nobody => olemis
Old description:
New description:
For practical (implementation) reasons submit buttons below ''add
comment'' textarea were removed in #345 . We should bring them back to
life soon .
--
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/347#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #347: Include sumbit button for comments ,
lost after #345
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#347: Include sumbit button for comments , lost after #345
--------------------------+------------------------------------
Reporter: olemis | Owner: olemis
Type: enhancement | Status: assigned
Priority: critical | Milestone: Release 4
Component: ui design | Version:
Resolution: | Keywords: ticket web_ui comments
--------------------------+------------------------------------
Comment (by gjm):
that is, the above instead of {{{$('#propertyform .buttons').hide();}}}
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/347#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #347: Include submit button for comments,
lost after #345 (was: Include sumbit button for comments ,
lost after #345)
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#347: Include submit button for comments, lost after #345
--------------------------+------------------------------------
Reporter: olemis | Owner: olemis
Type: enhancement | Status: closed
Priority: critical | Milestone: Release 4
Component: ui design | Version:
Resolution: fixed | Keywords: ticket web_ui comments
--------------------------+------------------------------------
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/347#comment:8>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #347: Include sumbit button for comments ,
lost after #345
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#347: Include sumbit button for comments , lost after #345
--------------------------+------------------------------------
Reporter: olemis | Owner: olemis
Type: enhancement | Status: assigned
Priority: critical | Milestone: Release 4
Component: ui design | Version:
Resolution: | Keywords: ticket web_ui comments
--------------------------+------------------------------------
Changes (by gjm):
* priority: minor => critical
* milestone: => Release 4
Comment:
reviewing the problem, I don't think #345 is quite good enough without
this. For a start, it looks like you have to put the ticket into the edit
state to be able to submit the ticket.
A possible fix for that might be something like:
{{{
#!javascript
$('#propertyform .buttons [name="submit"]').click(function (e) {
if ($('button#edit-submit').length) {
$('button#edit-submit').click();
e.preventDefault();
}
});
}}}
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/347#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #347: Include sumbit button for comments ,
lost after #345
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#347: Include sumbit button for comments , lost after #345
--------------------------+------------------------------------
Reporter: olemis | Owner: olemis
Type: enhancement | Status: assigned
Priority: minor | Milestone:
Component: ui design | Version:
Resolution: | Keywords: ticket web_ui comments
--------------------------+------------------------------------
Changes (by olemis):
* priority: major => minor
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/347#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker