[GitHub] [incubator-zipkin] adriancole commented on issue #2611: Handle exceptions without message.

[GitBox <gi...@apache.org>]

adriancole commented on issue #2611: Handle exceptions without message.
URL: https://github.com/apache/incubator-zipkin/pull/2611#issuecomment-496460466
 
 
   tribal knowledge deserving to be in the readme.
   
   yep we tend to use debug or finer for anything that can end up on request
   scope. this limits info/warn to things lifecycle in nature. metrics should
   indicate when to turn up logging.
   
   currently our exception metrics to degree exist aren't likely fancy. I
   remember finagle having the last 3 causes or something in the metric name
   which is handy for scala where there is a different type for everything
   maybe less so java excepting that it can identify NPE per second heh.
   
   anyway sorry about the curt message earlier.. blipped online and will soon
   be stably so. thanks for the help!
   
   On Tue, May 28, 2019, 7:32 AM Anuraag Agrawal <no...@github.com>
   wrote:
   
   > *@anuraaga* commented on this pull request.
   > ------------------------------
   >
   > In
   > zipkin-server/src/main/java/zipkin2/server/internal/ZipkinHttpCollector.java
   > <https://github.com/apache/incubator-zipkin/pull/2611#discussion_r287934864>
   > :
   >
   > >    @Override
   >    public HttpResponse handleException(RequestContext ctx, HttpRequest req, Throwable cause) {
   >      ZipkinHttpCollector.metrics.incrementMessagesDropped();
   > +
   > +    LOGGER.warn("Unexpected error handling request.", cause);
   >
   > Good point, moved the logging so it's for cases that aren't bad requests,
   > which we probably do need to see for debugging issues.
   >
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-zipkin/pull/2611?email_source=notifications&email_token=AAAPVV6V57SJPRTFKFX3QULPXS7WNA5CNFSM4HO2KIB2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBZZY6BQ#discussion_r287934864>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/AAAPVVYKBQH4A3BVIFVOCO3PXS7WNANCNFSM4HO2KIBQ>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services