You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucy.apache.org by ma...@apache.org on 2011/02/22 00:38:21 UTC
[lucy-commits] svn commit: r1073188 - in /incubator/lucy/trunk/clownfish:
lib/Clownfish/Binding/Perl.pm lib/Clownfish/Class.pm t/400-class.t
Author: marvin
Date: Mon Feb 21 23:38:21 2011
New Revision: 1073188
URL: http://svn.apache.org/viewvc?rev=1073188&view=rev
Log:
Remove unused method file_path() from Clownfish::Class.
Modified:
incubator/lucy/trunk/clownfish/lib/Clownfish/Binding/Perl.pm
incubator/lucy/trunk/clownfish/lib/Clownfish/Class.pm
incubator/lucy/trunk/clownfish/t/400-class.t
Modified: incubator/lucy/trunk/clownfish/lib/Clownfish/Binding/Perl.pm
URL: http://svn.apache.org/viewvc/incubator/lucy/trunk/clownfish/lib/Clownfish/Binding/Perl.pm?rev=1073188&r1=1073187&r2=1073188&view=diff
==============================================================================
--- incubator/lucy/trunk/clownfish/lib/Clownfish/Binding/Perl.pm (original)
+++ incubator/lucy/trunk/clownfish/lib/Clownfish/Binding/Perl.pm Mon Feb 21 23:38:21 2011
@@ -277,8 +277,6 @@ sub prepare_pod {
# Compare against existing file; rewrite if changed.
my $pod_file_path
= catfile( $lib_dir, split( '::', $class_name ) ) . ".pod";
-
- $class->file_path( $lib_dir, ".pod" );
my $existing = "";
if ( -e $pod_file_path ) {
open( my $pod_fh, "<", $pod_file_path )
Modified: incubator/lucy/trunk/clownfish/lib/Clownfish/Class.pm
URL: http://svn.apache.org/viewvc/incubator/lucy/trunk/clownfish/lib/Clownfish/Class.pm?rev=1073188&r1=1073187&r2=1073188&view=diff
==============================================================================
--- incubator/lucy/trunk/clownfish/lib/Clownfish/Class.pm (original)
+++ incubator/lucy/trunk/clownfish/lib/Clownfish/Class.pm Mon Feb 21 23:38:21 2011
@@ -195,15 +195,6 @@ sub DESTROY {
$self->_destroy;
}
-sub file_path {
- my ( $self, $base_dir, $ext ) = @_;
- my @components = split( '::', $self->get_source_class );
- unshift @components, $base_dir
- if defined $base_dir;
- $components[-1] .= $ext;
- return catfile(@components);
-}
-
sub include_h {
my $self = shift;
my @components = split( '::', $self->get_source_class );
@@ -555,14 +546,6 @@ Bequeath all inherited methods and membe
Return this class and all its child classes as an array, where all children
appear after their parent nodes.
-=head2 file_path
-
- # /path/to/Foo/Bar.c, if source class is Foo::Bar.
- my $path = $class->file_path( '/path/to', '.c' );
-
-Provide an OS-specific path for a file relating to this class could be found,
-by joining together the components of the C<source_class> name.
-
=head2 include_h
my $relative_path = $class->include_h;
Modified: incubator/lucy/trunk/clownfish/t/400-class.t
URL: http://svn.apache.org/viewvc/incubator/lucy/trunk/clownfish/t/400-class.t?rev=1073188&r1=1073187&r2=1073188&view=diff
==============================================================================
--- incubator/lucy/trunk/clownfish/t/400-class.t (original)
+++ incubator/lucy/trunk/clownfish/t/400-class.t Mon Feb 21 23:38:21 2011
@@ -16,7 +16,7 @@
use strict;
use warnings;
-use Test::More tests => 53;
+use Test::More tests => 52;
use Clownfish::Class;
use Clownfish::Parser;
@@ -78,8 +78,6 @@ my $final_foo = Clownfish::Class->create
attributes => { dumpable => 1 },
);
ok( $final_foo->final, "final" );
-is( $final_foo->file_path( '/path/to', '.c', ),
- '/path/to/Foo/FooJr.c', "file_path" );
is( $final_foo->include_h, 'Foo/FooJr.h', "inlude_h uses source_class" );
is( $final_foo->get_parent_class_name, 'Foo::FooJr',
"get_parent_class_name" );