[GitHub] eatoncys edited a comment on issue #23010: [SPARK-26012][SQL]Null and '' values should not cause dynamic partition failure of string types

[GitBox <gi...@apache.org>]

eatoncys edited a comment on issue #23010: [SPARK-26012][SQL]Null and '' values should not cause dynamic partition failure of string types
URL: https://github.com/apache/spark/pull/23010#issuecomment-465429475
 
 
   @cloud-fan I'm not very sure about that: the `child` plan is converted from the `query` plan.
   The code for generating and executing `InsertIntoHadoopFsRelationCommand` is as follows：
   
   def writeAndRead(
         mode: SaveMode,
         **data: LogicalPlan,**
         outputColumnNames: Seq[String],
         **physicalPlan: SparkPlan**): BaseRelation = {
         ...
         case format: FileFormat =>
           **val cmd = planForWritingFileFormat(format, mode, _data_)**
          ...
           val resolved = cmd.copy(
             partitionColumns = resolvedPartCols,
             outputColumnNames = outputColumnNames)
           **resolved.run(sparkSession, _physicalPlan_)**
   
   InsertIntoHadoopFsRelationCommand is generated by planForWritingFileFormat, which using the `data` for `query` plan, and is executed by `resolved.run(sparkSession, physicalPlan)`, which using the `physicalPlan` for `child` plan.
   
   I'm not very sure, Is there anything wrong for me?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org