[GitHub] [bookkeeper] dlg99 commented on pull request #2975: Changing the routing of ledgers to journal directories

[GitBox <gi...@apache.org>]

dlg99 commented on pull request #2975:
URL: https://github.com/apache/bookkeeper/pull/2975#issuecomment-1033980716


   @1559924775 I hope you are still interested in fixing this issue.
   My PR https://github.com/apache/bookkeeper/pull/3023 fixes similar problem with routing of requests to threads, I think the routing logic change can be reused for the journals and it is faster than md5/murmur/other hashing. 
   
   As a follow up to the discussion https://github.com/apache/bookkeeper/issues/2974#issuecomment-1028054818 the change requires some additional thinking to prevent data loss during upgrade/downgrade.
   I think backwards compat tests can help with this, but you will need to add tests for upgrade from old version with 2 journal/2 data disks to the new version with changed routing. The test will need to repro the case when journal replay is needed etc. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org