You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Garrett Rooney <ro...@electricjellyfish.net> on 2002/07/25 02:09:23 UTC

svn log ending up with xml encoded data?

so i was playing with our new 'real damn fast' 'svn log', and i
noticed that when i check the log entry for revision 22 on
svn.collab.net, i get some odd output.

[rooneg@quicksilver:~ ] svn log -r 22 http://svn.collab.net/repos/svn
------------------------------------------------------------------------
rev 22:  joe | 2001-09-02 08:06:48 -0400 (Sun, 02 Sep 2001) | 5 lines

Fix "svn diff foo &gt; bar" output.

* diff.c (svn_cl__print_file_diff): Print diff headers using APR file
I/O to prevent output interleaving badly.

------------------------------------------------------------------------
[rooneg@quicksilver:~ ] 

i assume that's a > being encoded as &gt;...  anyone got an idea where
this is coming from?  is this just not getting unxml-encoded when we
get it back from ra_dav? or is there actually a &gt; in that message?

-garrett

-- 
garrett rooney                    Remember, any design flaw you're 
rooneg@electricjellyfish.net      sufficiently snide about becomes  
http://electricjellyfish.net/     a feature.       -- Dan Sugalski

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn log ending up with xml encoded data?

Posted by cm...@collab.net.
Garrett Rooney <ro...@electricjellyfish.net> writes:

> On Wed, Jul 24, 2002 at 09:15:58PM -0500, cmpilato@collab.net wrote:
> 
> > Hm.  It looks like it really is that way in the repos (and it just
> > revealed a bug in my tweak-log.cgi script).
> 
> huh.  weird.  wonder how that got there.
> 
> should have thought to check the tweak-log.cgi script.

It might have been there from before the revision where we actually
fixed that bug in the code.  Oh, yep, looks like it took a while to
fix the bug...:

------------------------------------------------------------------------
rev 88:  cmpilato | 2001-09-12 09:44:56 -0500 (Wed, 12 Sep 2001) | 4 lines
Changed paths:
   U /trunk/subversion/mod_dav_svn/deadprops.c

* deadprops.c

  (dav_svn_db_fetch): XML-escape properties before they hit the wire.

------------------------------------------------------------------------
rev 82:  cmpilato | 2001-09-11 10:51:57 -0500 (Tue, 11 Sep 2001) | 10 lines
Changed paths:
   U /trunk/subversion/include/svn_xml.h
   U /trunk/subversion/libsvn_subr/xml.c
   U /trunk/subversion/mod_dav_svn/deadprops.c

* libsvn_subr/xml.c
* include/svn_xml.h

  (svn_xml_unescape_string): New function.

* mod_dav_svn/deadprops.c

  (dav_svn_db_store): Un-xml-ize properties before storing in the
  filesystem.  &lt;grin&gt; Dare I try to "commit" &amp; 'test' this at the same
  time?

------------------------------------------------------------------------
rev 69:  cmpilato | 2001-09-08 01:43:57 -0500 (Sat, 08 Sep 2001) | 5 lines
Changed paths:
   U /trunk/subversion/libsvn_ra_dav/commit.c

* commit.c

  (apply_log_message): XML-escape our log messages over DAV &amp; test
  them with this &lt;&lt;&lt; amazing! &gt;&gt;&gt; log "message".


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn log ending up with xml encoded data?

Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On Wed, Jul 24, 2002 at 09:15:58PM -0500, cmpilato@collab.net wrote:

> Hm.  It looks like it really is that way in the repos (and it just
> revealed a bug in my tweak-log.cgi script).

huh.  weird.  wonder how that got there.

should have thought to check the tweak-log.cgi script.

thanks,

-garrett 

-- 
garrett rooney                    Remember, any design flaw you're 
rooneg@electricjellyfish.net      sufficiently snide about becomes  
http://electricjellyfish.net/     a feature.       -- Dan Sugalski

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn log ending up with xml encoded data?

Posted by cm...@collab.net.
Garrett Rooney <ro...@electricjellyfish.net> writes:

> so i was playing with our new 'real damn fast' 'svn log', and i
> noticed that when i check the log entry for revision 22 on
> svn.collab.net, i get some odd output.
> 
> [rooneg@quicksilver:~ ] svn log -r 22 http://svn.collab.net/repos/svn
> ------------------------------------------------------------------------
> rev 22:  joe | 2001-09-02 08:06:48 -0400 (Sun, 02 Sep 2001) | 5 lines
> 
> Fix "svn diff foo &gt; bar" output.
> 
> * diff.c (svn_cl__print_file_diff): Print diff headers using APR file
> I/O to prevent output interleaving badly.

Hm.  It looks like it really is that way in the repos (and it just
revealed a bug in my tweak-log.cgi script).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org