You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/07/11 04:04:15 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #41770: [SPARK-44264][ML][PYTHON] Write a Deepspeed Distributed Learning Class DeepspeedTorchDistributor

HyukjinKwon commented on code in PR #41770:
URL: https://github.com/apache/spark/pull/41770#discussion_r1259147630


##########
python/pyspark/ml/deepspeed/tests/test_deepspeed_distributor.py:
##########
@@ -0,0 +1,176 @@
+#

Review Comment:
   should add this file into https://github.com/apache/spark/blob/master/dev/sparktestsupport/modules.py so the test actually runs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org