You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "anmolnar (via GitHub)" <gi...@apache.org> on 2025/08/05 21:29:30 UTC
Re: [PR] HBASE-29328: Implement new HBase command: refresh_hfiles [hbase]
anmolnar commented on code in PR #7149:
URL: https://github.com/apache/hbase/pull/7149#discussion_r2255377866
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java:
##########
@@ -3661,4 +3661,28 @@ public FlushTableResponse flushTable(RpcController controller, FlushTableRequest
throw new ServiceException(ioe);
}
}
+
+ @Override
+ public MasterProtos.RefreshHFilesResponse refreshHFiles(RpcController controller,
+ MasterProtos.RefreshHFilesRequest request) throws ServiceException {
+ // TODO Check if table exists otherwise send exception.
Review Comment:
I agree. Since the PR is still in Draft mode, I guess these TODOs will be addressed in later commits.
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java:
##########
@@ -4557,4 +4559,49 @@ List<String>> adminCall(controller, stub, request.build(),
resp -> resp.getCachedFilesList()))
.serverName(serverName).call();
}
+
+ @Override
+ public CompletableFuture<Long> refreshHFiles(final TableName tableName) {
+ // Request builder
+ RefreshHFilesRequest.Builder request = RefreshHFilesRequest.newBuilder();
+ request.setTableName(ProtobufUtil.toProtoTableName(tableName));
Review Comment:
I think in case of a standard TableName it could be either a table name without namespace prefix, meaning a table in the default namespace or a table name with the namespace prefix. I guess it's handled later in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org