You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2020/01/06 11:19:09 UTC

[GitHub] [brooklyn-server] iuliana commented on issue #1075: Tidies - adjunct destroy, and better error messages

iuliana commented on issue #1075: Tidies - adjunct destroy, and better error messages
URL: https://github.com/apache/brooklyn-server/pull/1075#issuecomment-571102940
 
 
    Unused imports in:
   ```
   BrooklynComponentTemplateResolver,
   BasicBrooklynTypeRegistry,
   JcloudsWinrmingLiveTest,
   PeriodicEffectorPolicyTest (log is declared and not used as well),
   AdjunctResourceTest
   ```
   
   3 test failures:
   ```
   org.apache.brooklyn.camp.brooklyn.spi.dsl.TagsYamlTest.testBrooklynCampFailDslTags,
   org.apache.brooklyn.camp.brooklyn.spi.dsl.TagsYamlTest.testBrooklynCampTagsFailNonList,
   org.apache.brooklyn.camp.brooklyn.spi.dsl.DslYamlTest.testDslNonDeferredInvalidMethod
   ```
   
   Also in the root `pom.xml` some dependencies were downgraded, maybe a reason for doing so should be provided. The test failures prevent the merging of the branch.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services