[jira] [Commented] (FLINK-4459) Introduce SlotProvider for Scheduler

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-4459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15455704#comment-15455704 ] 

ASF GitHub Bot commented on FLINK-4459:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/2424
  
    I will try and rebase/merge this on top of #2447 and add this to the `flip-6` branch as soon as #2447 is approved.


> Introduce SlotProvider for Scheduler
> ------------------------------------
>
>                 Key: FLINK-4459
>                 URL: https://issues.apache.org/jira/browse/FLINK-4459
>             Project: Flink
>          Issue Type: Improvement
>          Components: Scheduler
>            Reporter: Till Rohrmann
>            Assignee: Kurt Young
>
> Currently the {{Scheduler}} maintains a queue of available instances which it scans if it needs a new slot. If it finds a suitable instance (having free slots available) it will allocate a slot from it. 
> This slot allocation logic can be factored out and be made available via a {{SlotProvider}} interface. The {{SlotProvider}} has methods to allocate a slot given a set of location preferences. Slots should be returned as {{Futures}}, because in the future the slot allocation might happen asynchronously (Flip-6). 
> In the first version, the {{SlotProvider}} implementation will simply encapsulate the existing slot allocation logic extracted from the {{Scheduler}}. When a slot is requested it will return a completed or failed future since the allocation happens synchronously.
> The refactoring will have the advantage to simplify the {{Scheduler}} class and to pave the way for upcoming refactorings (Flip-6).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)