You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Suma Shivaprasad (JIRA)" <ji...@apache.org> on 2018/06/12 01:44:00 UTC
[jira] [Commented] (YARN-8415) TimelineWebServices.getEntity should
throw a ForbiddenException(403) instead of 404 when ACL checks fail
[ https://issues.apache.org/jira/browse/YARN-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509057#comment-16509057 ]
Suma Shivaprasad commented on YARN-8415:
----------------------------------------
Removed logging of domainId for getEntity calls since it is not not passed in the call params. Thanks [~vinodkv] for the review.
> TimelineWebServices.getEntity should throw a ForbiddenException(403) instead of 404 when ACL checks fail
> --------------------------------------------------------------------------------------------------------
>
> Key: YARN-8415
> URL: https://issues.apache.org/jira/browse/YARN-8415
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Suma Shivaprasad
> Assignee: Suma Shivaprasad
> Priority: Major
> Attachments: YARN-8415.1.patch, YARN-8415.2.patch
>
>
> {noformat}
> private TimelineEntity doGetEntity(
> String entityType,
> String entityId,
> EnumSet<Field> fields,
> UserGroupInformation callerUGI) throws YarnException, IOException {
> TimelineEntity entity = null;
> entity =
> store.getEntity(entityId, entityType, fields);
> if (entity != null) {
> addDefaultDomainIdIfAbsent(entity);
> // check ACLs
> if (!timelineACLsManager.checkAccess(
> callerUGI, ApplicationAccessType.VIEW_APP, entity)) {
> entity = null; //Should differentiate from an entity get failure vs ACL check failure here by throwing an Exception.*
> }
> }
> return entity;
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org