You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "fuweng11 (via GitHub)" <gi...@apache.org> on 2023/10/11 08:56:01 UTC
[PR] [INLONG-9041][Manager] Support saving schema information when saving iceberg source [inlong]
fuweng11 opened a new pull request, #9042:
URL: https://github.com/apache/inlong/pull/9042
### Prepare a Pull Request
- Fixes #9041
### Motivation
Support saving schema information when saving iceberg source.
### Modifications
Support saving schema information when saving iceberg source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9041][Manager] Support saving schema information when saving iceberg source [inlong]
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #9042:
URL: https://github.com/apache/inlong/pull/9042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9041][Manager] Support saving schema information when saving iceberg source [inlong]
Posted by "EMsnap (via GitHub)" <gi...@apache.org>.
EMsnap commented on code in PR #9042:
URL: https://github.com/apache/inlong/pull/9042#discussion_r1354489875
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/source/StreamSourceOperator.java:
##########
@@ -116,4 +116,11 @@ default Map<String, List<StreamSource>> getSourcesMap(InlongGroupInfo groupInfo,
*/
void restartOpt(SourceRequest request, String operator);
+ /**
+ * Get the source field info.
+ *
+ * @param request request of source
Review Comment:
typo here and missing parameter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9041][Manager] Support saving schema information when saving iceberg source [inlong]
Posted by "fuweng11 (via GitHub)" <gi...@apache.org>.
fuweng11 commented on code in PR #9042:
URL: https://github.com/apache/inlong/pull/9042#discussion_r1354530248
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/source/StreamSourceOperator.java:
##########
@@ -116,4 +116,11 @@ default Map<String, List<StreamSource>> getSourcesMap(InlongGroupInfo groupInfo,
*/
void restartOpt(SourceRequest request, String operator);
+ /**
+ * Get the source field info.
+ *
+ * @param request request of source
Review Comment:
Fix.
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/source/iceberg/IcebergSourceOperator.java:
##########
@@ -83,4 +96,52 @@ public StreamSource getFromEntity(StreamSourceEntity entity) {
source.setFieldList(sourceFields);
return source;
}
+
+ @Override
+ @Transactional(rollbackFor = Throwable.class, isolation = Isolation.REPEATABLE_READ)
+ public void getFieldInfo(SourceRequest request, String operator) {
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9041][Manager] Support saving schema information when saving iceberg source [inlong]
Posted by "EMsnap (via GitHub)" <gi...@apache.org>.
EMsnap commented on code in PR #9042:
URL: https://github.com/apache/inlong/pull/9042#discussion_r1354508706
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/source/iceberg/IcebergSourceOperator.java:
##########
@@ -83,4 +96,52 @@ public StreamSource getFromEntity(StreamSourceEntity entity) {
source.setFieldList(sourceFields);
return source;
}
+
+ @Override
+ @Transactional(rollbackFor = Throwable.class, isolation = Isolation.REPEATABLE_READ)
+ public void getFieldInfo(SourceRequest request, String operator) {
Review Comment:
the method name is get field info but the actual action is update iceberg field info
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org