You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2016/04/01 22:25:02 UTC
Re: Review Request 44674: Supported image name specified with private
registry prefix.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44674/
-----------------------------------------------------------
(Updated April 1, 2016, 1:25 p.m.)
Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
Bugs: MESOS-4939
https://issues.apache.org/jira/browse/MESOS-4939
Repository: mesos
Description
-------
Supported image name specified with private registry prefix.
Diffs (updated)
-----
include/mesos/docker/spec.hpp 5fb6647cc02aa64fa9305b1ec6db9d6d81caf5f7
src/docker/spec.cpp 07c0b87ee1a3b6981adfc96f5a7add6f625374c1
src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp d3eccd9902a7896d52e6c79b13bd389bb6380b8d
Diff: https://reviews.apache.org/r/44674/diff/
Testing
-------
make check
sudo ./bin/mesos-test.sh --gtest_filter="ProvisionerDockerRegistryPullerTest"
Tested with private registry localhost:80/ubuntu
Thanks,
Gilbert Song
Re: Review Request 44674: Supported image name specified with private
registry prefix.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44674/#review126668
-----------------------------------------------------------
Patch looks great!
Reviews applied: [44672, 44673, 44674]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 1, 2016, 10:41 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44674/
> -----------------------------------------------------------
>
> (Updated April 1, 2016, 10:41 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-4939
> https://issues.apache.org/jira/browse/MESOS-4939
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Supported image name specified with private registry prefix.
>
>
> Diffs
> -----
>
> include/mesos/docker/spec.hpp 5fb6647cc02aa64fa9305b1ec6db9d6d81caf5f7
> src/docker/spec.cpp 07c0b87ee1a3b6981adfc96f5a7add6f625374c1
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp d3eccd9902a7896d52e6c79b13bd389bb6380b8d
>
> Diff: https://reviews.apache.org/r/44674/diff/
>
>
> Testing
> -------
>
> make check
>
> sudo ./bin/mesos-test.sh --gtest_filter="ProvisionerDockerRegistryPullerTest"
>
> Tested with private registry localhost:80/ubuntu
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 44674: Supported image name specified with private
registry prefix.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44674/#review126700
-----------------------------------------------------------
src/docker/spec.cpp (lines 103 - 105)
<https://reviews.apache.org/r/44674/#comment189721>
Always good to check it explicitly, but we should not get any segfault without this check.
- Gilbert Song
On April 2, 2016, 1:20 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44674/
> -----------------------------------------------------------
>
> (Updated April 2, 2016, 1:20 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-4939
> https://issues.apache.org/jira/browse/MESOS-4939
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Supported image name specified with private registry prefix.
>
>
> Diffs
> -----
>
> include/mesos/docker/spec.hpp 5fb6647cc02aa64fa9305b1ec6db9d6d81caf5f7
> src/docker/spec.cpp 07c0b87ee1a3b6981adfc96f5a7add6f625374c1
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp d3eccd9902a7896d52e6c79b13bd389bb6380b8d
>
> Diff: https://reviews.apache.org/r/44674/diff/
>
>
> Testing
> -------
>
> make check
>
> sudo ./bin/mesos-test.sh --gtest_filter="ProvisionerDockerRegistryPullerTest"
>
> Tested with private registry localhost:80/ubuntu
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 44674: Supported image name specified with private
registry prefix.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44674/#review126838
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On April 2, 2016, 8:20 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44674/
> -----------------------------------------------------------
>
> (Updated April 2, 2016, 8:20 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-4939
> https://issues.apache.org/jira/browse/MESOS-4939
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Supported image name specified with private registry prefix.
>
>
> Diffs
> -----
>
> include/mesos/docker/spec.hpp 5fb6647cc02aa64fa9305b1ec6db9d6d81caf5f7
> src/docker/spec.cpp 07c0b87ee1a3b6981adfc96f5a7add6f625374c1
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp d3eccd9902a7896d52e6c79b13bd389bb6380b8d
>
> Diff: https://reviews.apache.org/r/44674/diff/
>
>
> Testing
> -------
>
> make check
>
> sudo ./bin/mesos-test.sh --gtest_filter="ProvisionerDockerRegistryPullerTest"
>
> Tested with private registry localhost:80/ubuntu
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 44674: Supported image name specified with private
registry prefix.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44674/
-----------------------------------------------------------
(Updated April 2, 2016, 1:20 p.m.)
Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
Bugs: MESOS-4939
https://issues.apache.org/jira/browse/MESOS-4939
Repository: mesos
Description
-------
Supported image name specified with private registry prefix.
Diffs (updated)
-----
include/mesos/docker/spec.hpp 5fb6647cc02aa64fa9305b1ec6db9d6d81caf5f7
src/docker/spec.cpp 07c0b87ee1a3b6981adfc96f5a7add6f625374c1
src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp d3eccd9902a7896d52e6c79b13bd389bb6380b8d
Diff: https://reviews.apache.org/r/44674/diff/
Testing
-------
make check
sudo ./bin/mesos-test.sh --gtest_filter="ProvisionerDockerRegistryPullerTest"
Tested with private registry localhost:80/ubuntu
Thanks,
Gilbert Song
Re: Review Request 44674: Supported image name specified with private
registry prefix.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44674/
-----------------------------------------------------------
(Updated April 1, 2016, 3:41 p.m.)
Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
Bugs: MESOS-4939
https://issues.apache.org/jira/browse/MESOS-4939
Repository: mesos
Description
-------
Supported image name specified with private registry prefix.
Diffs (updated)
-----
include/mesos/docker/spec.hpp 5fb6647cc02aa64fa9305b1ec6db9d6d81caf5f7
src/docker/spec.cpp 07c0b87ee1a3b6981adfc96f5a7add6f625374c1
src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp d3eccd9902a7896d52e6c79b13bd389bb6380b8d
Diff: https://reviews.apache.org/r/44674/diff/
Testing
-------
make check
sudo ./bin/mesos-test.sh --gtest_filter="ProvisionerDockerRegistryPullerTest"
Tested with private registry localhost:80/ubuntu
Thanks,
Gilbert Song
Re: Review Request 44674: Supported image name specified with private
registry prefix.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44674/#review126655
-----------------------------------------------------------
Patch looks great!
Reviews applied: [44672, 44673, 44674]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 1, 2016, 8:25 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44674/
> -----------------------------------------------------------
>
> (Updated April 1, 2016, 8:25 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-4939
> https://issues.apache.org/jira/browse/MESOS-4939
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Supported image name specified with private registry prefix.
>
>
> Diffs
> -----
>
> include/mesos/docker/spec.hpp 5fb6647cc02aa64fa9305b1ec6db9d6d81caf5f7
> src/docker/spec.cpp 07c0b87ee1a3b6981adfc96f5a7add6f625374c1
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp d3eccd9902a7896d52e6c79b13bd389bb6380b8d
>
> Diff: https://reviews.apache.org/r/44674/diff/
>
>
> Testing
> -------
>
> make check
>
> sudo ./bin/mesos-test.sh --gtest_filter="ProvisionerDockerRegistryPullerTest"
>
> Tested with private registry localhost:80/ubuntu
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 44674: Supported image name specified with private
registry prefix.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44674/#review126657
-----------------------------------------------------------
src/docker/spec.cpp (lines 103 - 105)
<https://reviews.apache.org/r/44674/#comment189667>
Let's remove this. I think checking if 'registry' is empty or not should be done at the upper level.
If 'registry' is empty, just return None().
src/docker/spec.cpp (line 123)
<https://reviews.apache.org/r/44674/#comment189666>
Hum, I am thinking about returning Try<string> here. Return 'https' if port != 80 or not specified.
src/docker/spec.cpp (lines 125 - 127)
<https://reviews.apache.org/r/44674/#comment189665>
This is not needed.
src/docker/spec.cpp (line 142)
<https://reviews.apache.org/r/44674/#comment189668>
I think we should just return string here (instead of a Try). If registry is empty, return an empty string.
- Jie Yu
On April 1, 2016, 8:25 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44674/
> -----------------------------------------------------------
>
> (Updated April 1, 2016, 8:25 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-4939
> https://issues.apache.org/jira/browse/MESOS-4939
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Supported image name specified with private registry prefix.
>
>
> Diffs
> -----
>
> include/mesos/docker/spec.hpp 5fb6647cc02aa64fa9305b1ec6db9d6d81caf5f7
> src/docker/spec.cpp 07c0b87ee1a3b6981adfc96f5a7add6f625374c1
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp d3eccd9902a7896d52e6c79b13bd389bb6380b8d
>
> Diff: https://reviews.apache.org/r/44674/diff/
>
>
> Testing
> -------
>
> make check
>
> sudo ./bin/mesos-test.sh --gtest_filter="ProvisionerDockerRegistryPullerTest"
>
> Tested with private registry localhost:80/ubuntu
>
>
> Thanks,
>
> Gilbert Song
>
>