You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2022/07/29 19:56:30 UTC

[GitHub] [tinkerpop] vkagamlyk opened a new pull request, #1774: Fix dotnet tests for Windows GHA

vkagamlyk opened a new pull request, #1774:
URL: https://github.com/apache/tinkerpop/pull/1774

   Enabled running dotnet tests on Windows on GitHub Actions.
   
   Fixed dotnet tests for Windows GHA:
   - test ShouldUseSpecifiedEvaluationTimeout. The test checks that EvalTimeout parameter works. Usual test request waiting time on server before execution is ~10-25 seconds, so I increased timeout to have time to spare.
   - test ShouldHandleCloseMessageForInFlightRequestsAsync. In dotnet driver, sending requests and reading responses is carried out in different threads without synchronization. If an error occurs, it is processed by the reading thread (Connection.NotifyAboutConnectionFailure method), so there is a race condition between the two threads to read/update the connection.NrRequestsInFlight property (based on _callbackByRequestId field).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tinkerpop] spmallette merged pull request #1774: Fix dotnet tests for Windows GHA

Posted by GitBox <gi...@apache.org>.
spmallette merged PR #1774:
URL: https://github.com/apache/tinkerpop/pull/1774


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org