[GitHub] [apisix] nic-chen commented on a change in pull request #2776: feat(proxy-cache): the cache_zone field in the schema should be optional

[GitBox <gi...@apache.org>]

nic-chen commented on a change in pull request #2776:
URL: https://github.com/apache/apisix/pull/2776#discussion_r525237312



##########
File path: apisix/plugins/proxy-cache.lua
##########
@@ -34,7 +34,8 @@ local schema = {
     properties = {
         cache_zone = {
             type = "string",
-            minLength = 1
+            minLength = 1,

Review comment:
       should set a max length too.

##########
File path: t/plugin/proxy-cache.t
##########
@@ -94,9 +120,9 @@ __DATA__
        }
 --- request
 GET /t
---- error_code: 400
---- response_body eval
-qr/failed to check the configuration of plugin proxy-cache/
+--- error_code: 200

Review comment:
       we could remove this line when it's 200




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org