You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by lo...@apache.org on 2022/04/26 19:55:18 UTC

[beam] branch master updated: fixes copy by value error for bytes.Buffer in Error (#17469)

This is an automated email from the ASF dual-hosted git repository.

lostluck pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new 429afcdc57f fixes copy by value error for bytes.Buffer in Error (#17469)
429afcdc57f is described below

commit 429afcdc57f986b4861198efccc24e1b9972aa19
Author: Ritesh Ghorse <ri...@gmail.com>
AuthorDate: Tue Apr 26 15:55:11 2022 -0400

    fixes copy by value error for bytes.Buffer in Error (#17469)
---
 sdks/go/pkg/beam/core/graph/coder/panes_test.go | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sdks/go/pkg/beam/core/graph/coder/panes_test.go b/sdks/go/pkg/beam/core/graph/coder/panes_test.go
index 49088e7f60c..502d57e70d7 100644
--- a/sdks/go/pkg/beam/core/graph/coder/panes_test.go
+++ b/sdks/go/pkg/beam/core/graph/coder/panes_test.go
@@ -131,7 +131,7 @@ func TestPaneCoder(t *testing.T) {
 			}
 			got, err := DecodePane(&buf)
 			if err != nil {
-				t.Fatalf("failed to decode pane from buffer %v, got %v", buf, err)
+				t.Fatalf("failed to decode pane from buffer %v, got %v", &buf, err)
 			}
 			if want := input; !equalPanes(got, want) {
 				t.Errorf("got pane %v, want %v", got, want)
@@ -172,7 +172,7 @@ func TestEncodePane_bad(t *testing.T) {
 			var buf bytes.Buffer
 			err := EncodePane(input, &buf)
 			if err == nil {
-				t.Errorf("successfully encoded pane when it should have failed, got %v", buf)
+				t.Errorf("successfully encoded pane when it should have failed, got %v", &buf)
 			}
 		})
 	}