You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2019/12/22 08:27:43 UTC
[GitHub] [incubator-shardingsphere] HongJinFeng opened a new pull request
#3780: [bugfix]Fix encryption rules do not support uppercase fileds
HongJinFeng opened a new pull request #3780: [bugfix]Fix encryption rules do not support uppercase fileds
URL: https://github.com/apache/incubator-shardingsphere/pull/3780
Fixes #3309
Method rewrite of class EncryptInsertValueParameterRewriter get encryptor by logic column, which is got from SQLStatementContext was formated to lowercase by orm frame(like mybatis) . So if encryption rule use uppercase logic column, the rewrite method can not get encryptor by it. And then Encrypt-JDBC fail to rewrite the SQL.
Changes proposed in this pull request:
cache the original column as key of encrypt rule configuration as well as cache the lowercase column.(If format the column to lowercase directly. it cause other problem)
-
-
-
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] HongJinFeng commented on issue #3780:
[bugfix]Fix encryption rules do not support uppercase fileds
Posted by GitBox <gi...@apache.org>.
HongJinFeng commented on issue #3780: [bugfix]Fix encryption rules do not support uppercase fileds
URL: https://github.com/apache/incubator-shardingsphere/pull/3780#issuecomment-568246368
First, thanks for review.
It work with mix upper case and low case cause cache the original logic column as well as the lower case logic column(Whatever the column is, the rewrite method use lower case logic column to get encryptor).
There is another way i use before, See the pull request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] HongJinFeng closed pull request #3780:
[bugfix]Fix encryption rules do not support uppercase fileds
Posted by GitBox <gi...@apache.org>.
HongJinFeng closed pull request #3780: [bugfix]Fix encryption rules do not support uppercase fileds
URL: https://github.com/apache/incubator-shardingsphere/pull/3780
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services