[GitHub] [spark] cloud-fan commented on a change in pull request #27732: [SPARK-30984][SS]Add UI test for Structured Streaming UI

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #27732: [SPARK-30984][SS]Add UI test for Structured Streaming UI
URL: https://github.com/apache/spark/pull/27732#discussion_r387043021
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/ProgressReporter.scala
 ##########
 @@ -349,7 +349,7 @@ trait ProgressReporter extends Logging {
     result
   }
 
-  private def formatTimestamp(millis: Long): String = {
+  protected def formatTimestamp(millis: Long): String = {
     timestampFormat.format(new Date(millis))
 
 Review comment:
   This is also different from the previous code which use UTC: https://github.com/apache/spark/pull/27732/files#diff-3ff3668ba061d3b690c7bfe9e8f0db32L35

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org