You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/13 23:31:15 UTC
[GitHub] [spark] attilapiros opened a new pull request #31559: [WIP][SPARK-34433] Lock Jekyll version by Gemfile and Bundler
attilapiros opened a new pull request #31559:
URL: https://github.com/apache/spark/pull/31559
### What changes were proposed in this pull request?
Improving the documentation and release process by pinning Jekyll version by Gemfile and Bundler.
### Why are the changes needed?
Using different Jekyll versions can generate different output documents.
This PR standardize the process.
### Does this PR introduce _any_ user-facing change?
No, assuming the release was done via docker by using `do-release-docker.sh`.
In that case there should be no difference at all as the same Jekyll version is specified in the Gemfile.
### How was this patch tested?
Doc generation step was triggered via teh docker release:
```
$ ./do-release-docker.sh -d ~/working -n -s docs
...
========================
= Building documentation...
Command: /opt/spark-rm/release-build.sh docs
Log file: docs.log
Skipping publish step.
```
The docs.log contains the followings:
```
Building Spark docs
Fetching gem metadata from https://rubygems.org/.........
Using bundler 2.2.9
Fetching rb-fsevent 0.10.4
Fetching forwardable-extended 2.6.0
Fetching public_suffix 4.0.6
Fetching colorator 1.1.0
Fetching eventmachine 1.2.7
Fetching http_parser.rb 0.6.0
Fetching ffi 1.14.2
Fetching concurrent-ruby 1.1.8
Installing colorator 1.1.0
Installing forwardable-extended 2.6.0
Installing rb-fsevent 0.10.4
Installing public_suffix 4.0.6
Installing http_parser.rb 0.6.0 with native extensions
Installing eventmachine 1.2.7 with native extensions
Installing concurrent-ruby 1.1.8
Fetching rexml 3.2.4
Fetching liquid 4.0.3
Installing ffi 1.14.2 with native extensions
Installing rexml 3.2.4
Installing liquid 4.0.3
Fetching mercenary 0.4.0
Installing mercenary 0.4.0
Fetching rouge 3.26.0
Installing rouge 3.26.0
Fetching safe_yaml 1.0.5
Installing safe_yaml 1.0.5
Fetching unicode-display_width 1.7.0
Installing unicode-display_width 1.7.0
Fetching webrick 1.7.0
Installing webrick 1.7.0
Fetching pathutil 0.16.2
Fetching kramdown 2.3.0
Fetching terminal-table 2.0.0
Fetching addressable 2.7.0
Fetching i18n 1.8.9
Installing terminal-table 2.0.0
Installing pathutil 0.16.2
Installing i18n 1.8.9
Installing addressable 2.7.0
Installing kramdown 2.3.0
Fetching kramdown-parser-gfm 1.1.0
Installing kramdown-parser-gfm 1.1.0
Fetching rb-inotify 0.10.1
Fetching sassc 2.4.0
Fetching em-websocket 0.5.2
Installing rb-inotify 0.10.1
Installing em-websocket 0.5.2
Installing sassc 2.4.0 with native extensions
Fetching listen 3.4.1
Installing listen 3.4.1
Fetching jekyll-watch 2.2.1
Installing jekyll-watch 2.2.1
Fetching jekyll-sass-converter 2.1.0
Installing jekyll-sass-converter 2.1.0
Fetching jekyll 4.2.0
Installing jekyll 4.2.0
Fetching jekyll-redirect-from 0.16.0
Installing jekyll-redirect-from 0.16.0
Bundle complete! 4 Gemfile dependencies, 30 gems now installed.
Bundled gems are installed into `./.local_ruby_bundle`
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31559: [SPARK-34433][DOCS] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-781015964
To reviewers, I am merging this more in order to match with spark-website. In spark-website where we keep the generated HTMLs, the diff from jekyll versions causes confusions to contributors very often, and doing this will reduce maintenance overhead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31559: [SPARK-34433][DOCS] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-779585588
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39742/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31559: [SPARK-34433] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-778719714
**[Test build #135143 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135143/testReport)** for PR 31559 at commit [`2ba486e`](https://github.com/apache/spark/commit/2ba486e5c2ce00f84a2d2830416efbd98421440b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31559: [SPARK-34433][DOCS] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-781016206
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31559: [SPARK-34433][DOCS] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-779599246
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39742/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31559: [SPARK-34433] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-779512851
cc @dongjoon-hyun too FYI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #31559: [SPARK-34433][DOCS] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31559:
URL: https://github.com/apache/spark/pull/31559#discussion_r576489697
##########
File path: docs/Gemfile.lock
##########
@@ -0,0 +1,73 @@
+GEM
Review comment:
@attilapiros, thanks for working on this. How did you create this file out of curiosity?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31559: [WIP][SPARK-34433] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-778706439
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] attilapiros commented on a change in pull request #31559: [WIP][SPARK-34433] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
attilapiros commented on a change in pull request #31559:
URL: https://github.com/apache/spark/pull/31559#discussion_r575727769
##########
File path: dev/create-release/release-build.sh
##########
@@ -333,7 +333,13 @@ if [[ "$1" == "docs" ]]; then
echo "Building Spark docs"
cd docs
# TODO: Make configurable to add this: PRODUCTION=1
- PRODUCTION=1 RELEASE_VERSION="$SPARK_VERSION" jekyll build
+ if [ ! -f "Gemfile" ]; then
Review comment:
Using the fallback as release script can be used to build any Spark refs (see GIT_REF) where could be no Gemfile at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31559: [SPARK-34433] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-778734574
**[Test build #135143 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135143/testReport)** for PR 31559 at commit [`2ba486e`](https://github.com/apache/spark/commit/2ba486e5c2ce00f84a2d2830416efbd98421440b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31559: [SPARK-34433] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-778741200
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135144/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31559: [WIP][SPARK-34433] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-778724015
**[Test build #135144 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135144/testReport)** for PR 31559 at commit [`8604db2`](https://github.com/apache/spark/commit/8604db28b87b387bbdb3761df85fae292cd402a1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #31559: [SPARK-34433][DOCS] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #31559:
URL: https://github.com/apache/spark/pull/31559
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31559: [WIP][SPARK-34433] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-778694539
**[Test build #135142 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135142/testReport)** for PR 31559 at commit [`266bfcc`](https://github.com/apache/spark/commit/266bfcc4b3f8fa21930898b7014b69001f59cf5d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31559: [SPARK-34433][DOCS] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-779569054
**[Test build #135161 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135161/testReport)** for PR 31559 at commit [`d7928f3`](https://github.com/apache/spark/commit/d7928f3fe022fced62c12d50d45a7de16762b6f2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31559: [SPARK-34433] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-778737420
**[Test build #135144 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135144/testReport)** for PR 31559 at commit [`8604db2`](https://github.com/apache/spark/commit/8604db28b87b387bbdb3761df85fae292cd402a1).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31559: [WIP][SPARK-34433] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-778731061
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39724/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31559: [SPARK-34433] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-778733679
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39725/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31559: [SPARK-34433][DOCS] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-781020119
@attilapiros, would you mind sending an email to the dev mailing list to say that our documentation build way changed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31559: [WIP][SPARK-34433] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-778719714
**[Test build #135143 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135143/testReport)** for PR 31559 at commit [`2ba486e`](https://github.com/apache/spark/commit/2ba486e5c2ce00f84a2d2830416efbd98421440b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31559: [SPARK-34433] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-778741200
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135144/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #31559: [SPARK-34433][DOCS] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31559:
URL: https://github.com/apache/spark/pull/31559#discussion_r576489845
##########
File path: docs/Gemfile
##########
@@ -0,0 +1,6 @@
+source "https://rubygems.org"
Review comment:
```suggestion
#
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements. See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
source "https://rubygems.org"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31559: [SPARK-34433][DOCS] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-779569054
**[Test build #135161 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135161/testReport)** for PR 31559 at commit [`d7928f3`](https://github.com/apache/spark/commit/d7928f3fe022fced62c12d50d45a7de16762b6f2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31559: [WIP][SPARK-34433] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-778730683
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39725/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #31559: [SPARK-34433][DOCS] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31559:
URL: https://github.com/apache/spark/pull/31559#discussion_r576489904
##########
File path: docs/Gemfile.lock
##########
@@ -0,0 +1,73 @@
+GEM
Review comment:
```suggestion
#
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements. See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
GEM
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31559: [SPARK-34433][DOCS] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-781016043
The last was the comment only change. I am merging it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #31559: [SPARK-34433][DOCS] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31559:
URL: https://github.com/apache/spark/pull/31559#discussion_r578103327
##########
File path: dev/run-tests.py
##########
@@ -240,18 +240,19 @@ def run_sparkr_style_checks():
def build_spark_documentation():
set_title_and_block("Building Spark Documentation", "BLOCK_DOCUMENTATION")
- os.environ["PRODUCTION"] = "1 jekyll build"
+ os.environ["PRODUCTION"] = "1"
os.chdir(os.path.join(SPARK_HOME, "docs"))
- jekyll_bin = which("jekyll")
+ bundle_bin = which("bundle")
- if not jekyll_bin:
- print("[error] Cannot find a version of `jekyll` on the system; please",
- " install one and retry to build documentation.")
+ if not bundle_bin:
+ print("[error] Cannot find a version of `bunlde` on the system; please",
Review comment:
```suggestion
print("[error] Cannot find a version of `bundle` on the system; please",
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31559: [SPARK-34433] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-778724015
**[Test build #135144 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135144/testReport)** for PR 31559 at commit [`8604db2`](https://github.com/apache/spark/commit/8604db28b87b387bbdb3761df85fae292cd402a1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31559: [WIP][SPARK-34433] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-778705520
**[Test build #135142 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135142/testReport)** for PR 31559 at commit [`266bfcc`](https://github.com/apache/spark/commit/266bfcc4b3f8fa21930898b7014b69001f59cf5d).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] attilapiros commented on pull request #31559: [SPARK-34433][DOCS] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
attilapiros commented on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-781098054
@HyukjinKwon Thanks! Certainly! I will send a mail about this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] attilapiros commented on pull request #31559: [SPARK-34433] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
attilapiros commented on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-778732909
cc @srowen @HyukjinKwon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] attilapiros commented on a change in pull request #31559: [WIP][SPARK-34433] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
attilapiros commented on a change in pull request #31559:
URL: https://github.com/apache/spark/pull/31559#discussion_r575727769
##########
File path: dev/create-release/release-build.sh
##########
@@ -333,7 +333,13 @@ if [[ "$1" == "docs" ]]; then
echo "Building Spark docs"
cd docs
# TODO: Make configurable to add this: PRODUCTION=1
- PRODUCTION=1 RELEASE_VERSION="$SPARK_VERSION" jekyll build
+ if [ ! -f "Gemfile" ]; then
Review comment:
As release script can be used to build any Spark refs (see GIT_REF) where could be no Gemfile at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #31559: [SPARK-34433][DOCS] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31559:
URL: https://github.com/apache/spark/pull/31559#discussion_r576538554
##########
File path: docs/Gemfile.lock
##########
@@ -0,0 +1,73 @@
+GEM
Review comment:
👌
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31559: [SPARK-34433][DOCS] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-779576432
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39742/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31559: [SPARK-34433][DOCS] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-779599246
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39742/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] attilapiros commented on a change in pull request #31559: [SPARK-34433][DOCS] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
attilapiros commented on a change in pull request #31559:
URL: https://github.com/apache/spark/pull/31559#discussion_r576529050
##########
File path: docs/Gemfile.lock
##########
@@ -0,0 +1,73 @@
+GEM
Review comment:
I would not do this as this content will be overwritten every time we increase the version of Jekyll or any other gem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31559: [SPARK-34433][DOCS] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-779619887
**[Test build #135161 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135161/testReport)** for PR 31559 at commit [`d7928f3`](https://github.com/apache/spark/commit/d7928f3fe022fced62c12d50d45a7de16762b6f2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31559: [SPARK-34433][DOCS] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-779627203
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135161/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] attilapiros commented on a change in pull request #31559: [SPARK-34433][DOCS] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
attilapiros commented on a change in pull request #31559:
URL: https://github.com/apache/spark/pull/31559#discussion_r576528698
##########
File path: docs/Gemfile.lock
##########
@@ -0,0 +1,73 @@
+GEM
Review comment:
You are welcome! I bumped into this problem in the spark-website where it is really annoying because of the diffs it generates.
As it is given in the description:
> docs/Gemfile.lock is generated by the "bundle install".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31559: [WIP][SPARK-34433] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-778731061
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39724/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31559: [WIP][SPARK-34433] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-778706440
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31559: [SPARK-34433] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-778736296
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31559: [SPARK-34433][DOCS] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-779627203
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135161/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31559: [WIP][SPARK-34433] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-778694539
**[Test build #135142 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135142/testReport)** for PR 31559 at commit [`266bfcc`](https://github.com/apache/spark/commit/266bfcc4b3f8fa21930898b7014b69001f59cf5d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31559: [SPARK-34433] Lock Jekyll version by Gemfile and Bundler
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31559:
URL: https://github.com/apache/spark/pull/31559#issuecomment-778736297
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org