You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/05/14 17:13:49 UTC
[GitHub] [superset] michael-s-molina commented on a change in pull request #14463: refactor: refactor Icon to Icons in sqlEditor component
michael-s-molina commented on a change in pull request #14463:
URL: https://github.com/apache/superset/pull/14463#discussion_r632675081
##########
File path: superset-frontend/src/SqlLab/components/SqlEditor.jsx
##########
@@ -638,7 +638,9 @@ class SqlEditor extends React.PureComponent {
this.props.defaultQueryLimit,
)}
</span>
- <Icon name="triangle-down" />
+ <Icons.TriangleDown
+ iconColor={supersetTheme.colors.grayscale.base}
Review comment:
You shouldn't access the `theme` directly from `@superset-ui/core`. You can use `useTheme` or `withTheme`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org