You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2017/08/15 07:00:34 UTC
Review Request 61640: Improved the reason and message for killed
queued tasks updates.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61640/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar and Vinod Kone.
Repository: mesos
Description
-------
Previously, if a task was killed before delivery to a registering
executor, we sent REASON_EXECUTOR_UNREGISTERED with a message of
"Unregistered executor". Whereas this case is just that the task
was killed while queued.
Diffs
-----
src/slave/slave.cpp 7381530515f86faf4c3e8f82bcd9483f6cf0498b
src/tests/slave_recovery_tests.cpp 9ba6f6005c2edce67e1f63005518ab71ac981423
src/tests/slave_tests.cpp 1d9d142ed9e801b79535a2c28f5a94ffbf1bf160
Diff: https://reviews.apache.org/r/61640/diff/1/
Testing
-------
Updated the tests.
Thanks,
Benjamin Mahler
Re: Review Request 61640: Improved the reason and message for tasks
killed before delivery.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61640/#review183677
-----------------------------------------------------------
Fix it, then Ship it!
include/mesos/mesos.proto
Lines 2179 (patched)
<https://reviews.apache.org/r/61640/#comment259745>
s/REASON_TASK_KILLED_BEFORE_DELIVERY/REASON_TASK_KILLED_DURING_LAUNCH/ ?
since "launch" is a known concept/term in mesos.
- Vinod Kone
On Aug. 22, 2017, 7:45 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61640/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2017, 7:45 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, if a task was killed before delivery to a registering
> executor, we sent REASON_EXECUTOR_UNREGISTERED with a message of
> "Unregistered executor" in the agent, and the master sent no reason.
> This introduces a REASON_TASK_KILLED_BEFORE_DELIVERY to clarify
> this case to frameworks.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto d91c96814dfcd03a4390d80f90acd61b5e4aebdd
> include/mesos/v1/mesos.proto 6a1d011a45dcead644300d6becedcbd4bc1f5a96
> src/master/master.cpp 7f38a5e21884546d4b4c866ca5918db779af8f99
> src/slave/slave.cpp 50d2a10cd68f6611efd4e691e5325e6e0c06f33a
> src/tests/master_authorization_tests.cpp b41b4a111a51f1b7f774334d5867528f007adaff
> src/tests/slave_recovery_tests.cpp b3825d13b12ee0da110b30baba5f5e68051b8e97
> src/tests/slave_tests.cpp a8b46a450c4f3986139390aeed5544e7f9091781
>
>
> Diff: https://reviews.apache.org/r/61640/diff/2/
>
>
> Testing
> -------
>
> Updated the tests.
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 61640: Improved the reason and message for tasks
killed before delivery.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61640/
-----------------------------------------------------------
(Updated Aug. 22, 2017, 7:45 p.m.)
Review request for mesos, Anand Mazumdar and Vinod Kone.
Changes
-------
* Rebased
* Marked the old reason as no longer used
* Introduced a `REASON_TASK_KILLED_BEFORE_DELIVERY`
Summary (updated)
-----------------
Improved the reason and message for tasks killed before delivery.
Repository: mesos
Description (updated)
-------
Previously, if a task was killed before delivery to a registering
executor, we sent REASON_EXECUTOR_UNREGISTERED with a message of
"Unregistered executor" in the agent, and the master sent no reason.
This introduces a REASON_TASK_KILLED_BEFORE_DELIVERY to clarify
this case to frameworks.
Diffs (updated)
-----
include/mesos/mesos.proto d91c96814dfcd03a4390d80f90acd61b5e4aebdd
include/mesos/v1/mesos.proto 6a1d011a45dcead644300d6becedcbd4bc1f5a96
src/master/master.cpp 7f38a5e21884546d4b4c866ca5918db779af8f99
src/slave/slave.cpp 50d2a10cd68f6611efd4e691e5325e6e0c06f33a
src/tests/master_authorization_tests.cpp b41b4a111a51f1b7f774334d5867528f007adaff
src/tests/slave_recovery_tests.cpp b3825d13b12ee0da110b30baba5f5e68051b8e97
src/tests/slave_tests.cpp a8b46a450c4f3986139390aeed5544e7f9091781
Diff: https://reviews.apache.org/r/61640/diff/2/
Changes: https://reviews.apache.org/r/61640/diff/1-2/
Testing
-------
Updated the tests.
Thanks,
Benjamin Mahler
Re: Review Request 61640: Improved the reason and message for tasks
killed before delivery.
Posted by Benjamin Mahler <bm...@apache.org>.
> On Aug. 18, 2017, 11:37 p.m., Vinod Kone wrote:
> > src/slave/slave.cpp
> > Lines 3033 (patched)
> > <https://reviews.apache.org/r/61640/diff/1/?file=1797191#file1797191line3033>
> >
> > Can you add a TODO to the protobuf that contains this enum saying that it is no longer used.
> >
> > Also, should we use a better named enum for this case? I would like to move towards all mesos generated updates to have reasons.
Introduced a `REASON_TASK_KILLED_BEFORE_DELIVERY` for these cases and updated the master side as well.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61640/#review183281
-----------------------------------------------------------
On Aug. 22, 2017, 7:45 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61640/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2017, 7:45 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, if a task was killed before delivery to a registering
> executor, we sent REASON_EXECUTOR_UNREGISTERED with a message of
> "Unregistered executor" in the agent, and the master sent no reason.
> This introduces a REASON_TASK_KILLED_BEFORE_DELIVERY to clarify
> this case to frameworks.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto d91c96814dfcd03a4390d80f90acd61b5e4aebdd
> include/mesos/v1/mesos.proto 6a1d011a45dcead644300d6becedcbd4bc1f5a96
> src/master/master.cpp 7f38a5e21884546d4b4c866ca5918db779af8f99
> src/slave/slave.cpp 50d2a10cd68f6611efd4e691e5325e6e0c06f33a
> src/tests/master_authorization_tests.cpp b41b4a111a51f1b7f774334d5867528f007adaff
> src/tests/slave_recovery_tests.cpp b3825d13b12ee0da110b30baba5f5e68051b8e97
> src/tests/slave_tests.cpp a8b46a450c4f3986139390aeed5544e7f9091781
>
>
> Diff: https://reviews.apache.org/r/61640/diff/2/
>
>
> Testing
> -------
>
> Updated the tests.
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 61640: Improved the reason and message for killed
queued tasks updates.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61640/#review183281
-----------------------------------------------------------
src/slave/slave.cpp
Lines 3033 (patched)
<https://reviews.apache.org/r/61640/#comment259299>
Can you add a TODO to the protobuf that contains this enum saying that it is no longer used.
Also, should we use a better named enum for this case? I would like to move towards all mesos generated updates to have reasons.
- Vinod Kone
On Aug. 15, 2017, 7 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61640/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2017, 7 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, if a task was killed before delivery to a registering
> executor, we sent REASON_EXECUTOR_UNREGISTERED with a message of
> "Unregistered executor". Whereas this case is just that the task
> was killed while queued.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 7381530515f86faf4c3e8f82bcd9483f6cf0498b
> src/tests/slave_recovery_tests.cpp 9ba6f6005c2edce67e1f63005518ab71ac981423
> src/tests/slave_tests.cpp 1d9d142ed9e801b79535a2c28f5a94ffbf1bf160
>
>
> Diff: https://reviews.apache.org/r/61640/diff/1/
>
>
> Testing
> -------
>
> Updated the tests.
>
>
> Thanks,
>
> Benjamin Mahler
>
>