You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@age.apache.org by GitBox <gi...@apache.org> on 2022/02/15 23:49:53 UTC

[GitHub] [incubator-age] JoshInnis commented on a change in pull request #185: feat: Introduce `enable_auto_column_conversion`

JoshInnis commented on a change in pull request #185:
URL: https://github.com/apache/incubator-age/pull/185#discussion_r807414489



##########
File path: src/backend/parser/cypher_analyze.c
##########
@@ -612,10 +623,18 @@ static Query *analyze_cypher_and_coerce(List *stmt, RangeTblFunction *rtfunc,
     // check the number of attributes first
     if (attr_count != rtfunc->funccolcount)
     {
-        ereport(ERROR,
-                (errcode(ERRCODE_DATATYPE_MISMATCH),
-                 errmsg("return row and column definition list do not match"),
-                 parser_errposition(pstate, exprLocation(rtfunc->funcexpr))));
+        if (age_guc_enable_auto_column_conversion)

Review comment:
       Should the functionality be: if the column definition list doesn't match: check the flag, or if the flag is enabled don't check the column definition list?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org