You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "orionlibs (via GitHub)" <gi...@apache.org> on 2023/06/29 21:25:56 UTC
[GitHub] [commons-lang] orionlibs opened a new pull request, #1071: LANG-1695
orionlibs opened a new pull request, #1071:
URL: https://github.com/apache/commons-lang/pull/1071
allowed for a number (positive or negative) that has only one decimal point and it is at the end of the input, is treated as a valid number
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] codecov-commenter commented on pull request #1071: LANG-1695
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1071:
URL: https://github.com/apache/commons-lang/pull/1071#issuecomment-1613842600
## [Codecov](https://app.codecov.io/gh/apache/commons-lang/pull/1071?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1071](https://app.codecov.io/gh/apache/commons-lang/pull/1071?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (75393a3) into [master](https://app.codecov.io/gh/apache/commons-lang/commit/f4665d0bc604ed9bb1aae3c93e99d4eee5027c1a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f4665d0) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #1071 +/- ##
============================================
- Coverage 92.07% 92.07% -0.01%
Complexity 7501 7501
============================================
Files 194 194
Lines 15743 15741 -2
Branches 2902 2901 -1
============================================
- Hits 14496 14493 -3
Misses 674 674
- Partials 573 574 +1
```
| [Impacted Files](https://app.codecov.io/gh/apache/commons-lang/pull/1071?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ava/org/apache/commons/lang3/math/NumberUtils.java](https://app.codecov.io/gh/apache/commons-lang/pull/1071?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvbWF0aC9OdW1iZXJVdGlscy5qYXZh) | `94.77% <0.00%> (-0.25%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] orionlibs commented on a diff in pull request #1071: LANG-1695: NumberUtils::isParseable does not recognise numbers ending in dot
Posted by "orionlibs (via GitHub)" <gi...@apache.org>.
orionlibs commented on code in PR #1071:
URL: https://github.com/apache/commons-lang/pull/1071#discussion_r1265949881
##########
src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java:
##########
@@ -918,7 +918,8 @@ public void testIsParsable() {
assertFalse(NumberUtils.isParsable("pendro"));
assertFalse(NumberUtils.isParsable("64, 2"));
assertFalse(NumberUtils.isParsable("64.2.2"));
- assertFalse(NumberUtils.isParsable("64."));
+ assertTrue(NumberUtils.isParsable("64."));
Review Comment:
@elharo sorry. My understanding of the ticket is that 64. is valid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #1071: LANG-1695: NumberUtils::isParseable does not recognise numbers ending in dot
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #1071:
URL: https://github.com/apache/commons-lang/pull/1071#issuecomment-1656905369
@elharo
I agree with you on the purpose of the API.
I'd like to revisit the implementation though: Why are we half-baked-with-bugs parsing the input instead of just try-catching what we claim is input that will or not throw an exception when we a user actually calls on the number APIs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on a diff in pull request #1071: LANG-1695: NumberUtils::isParseable does not recognise numbers ending in dot
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on code in PR #1071:
URL: https://github.com/apache/commons-lang/pull/1071#discussion_r1277339340
##########
src/main/java/org/apache/commons/lang3/math/NumberUtils.java:
##########
@@ -1776,7 +1773,7 @@ private static boolean withDecimalsParsing(final String str, final int beginIdx)
if (decimalPoints > 1) {
return false;
}
- if (!isDecimalPoint && !Character.isDigit(str.charAt(i))) {
+ if (!isDecimalPoint && !Character.isDigit(str.charAt(i)) && !(i == str.length() - 1 && str.charAt(i) == '.')) {
Review Comment:
What happens in countries that flip the meaning of the comma and period?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #1071: LANG-1695
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #1071:
URL: https://github.com/apache/commons-lang/pull/1071#issuecomment-1616689605
@orionlibs
Thank you for the PR. Would you please reply in the Jira ticket to the comment https://issues.apache.org/jira/browse/LANG-1695?focusedCommentId=17709278&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17709278
We really need to make sure we are not creating trouble for ourselves ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] orionlibs commented on a diff in pull request #1071: LANG-1695: NumberUtils::isParseable does not recognise numbers ending in dot
Posted by "orionlibs (via GitHub)" <gi...@apache.org>.
orionlibs commented on code in PR #1071:
URL: https://github.com/apache/commons-lang/pull/1071#discussion_r1277199209
##########
src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java:
##########
@@ -918,7 +918,8 @@ public void testIsParsable() {
assertFalse(NumberUtils.isParsable("pendro"));
assertFalse(NumberUtils.isParsable("64, 2"));
assertFalse(NumberUtils.isParsable("64.2.2"));
- assertFalse(NumberUtils.isParsable("64."));
+ assertTrue(NumberUtils.isParsable("64."));
Review Comment:
you are right. I added a test for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #1071: LANG-1695
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #1071:
URL: https://github.com/apache/commons-lang/pull/1071#issuecomment-1617054177
> @garydgregory I am new to open source contribution and a week ago I started with Apache. I applied for a JIRA account, but I was denied one (with no reason given). So, I cannot login to JIRA. Here is the email from apache: We regret to inform you that, upon reviewing your request for a new Jira account connected with The Apache Software Foundation, the commons project has chosen to deny the request. We therefore will not create the Jira account.
>
> The following reason was given: No reason given.
>
> If you wish to appeal this decision, you may do so either directly with the commons project, or by contacting the ASF Infrastructure team at: [users@infra.apache.org](mailto:users@infra.apache.org)
@orionlibs
Please apply again for a Jira account, I'll watch for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] elharo commented on a diff in pull request #1071: LANG-1695: NumberUtils::isParseable does not recognise numbers ending in dot
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #1071:
URL: https://github.com/apache/commons-lang/pull/1071#discussion_r1276625041
##########
src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java:
##########
@@ -918,7 +918,8 @@ public void testIsParsable() {
assertFalse(NumberUtils.isParsable("pendro"));
assertFalse(NumberUtils.isParsable("64, 2"));
assertFalse(NumberUtils.isParsable("64.2.2"));
- assertFalse(NumberUtils.isParsable("64."));
+ assertTrue(NumberUtils.isParsable("64."));
Review Comment:
64. is valid but 64.. (two periods) is not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] LANG-1695: NumberUtils::isParseable does not recognise numbers ending in dot [commons-lang]
Posted by "orionlibs (via GitHub)" <gi...@apache.org>.
orionlibs closed pull request #1071: LANG-1695: NumberUtils::isParseable does not recognise numbers ending in dot
URL: https://github.com/apache/commons-lang/pull/1071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] orionlibs commented on a diff in pull request #1071: LANG-1695: NumberUtils::isParseable does not recognise numbers ending in dot
Posted by "orionlibs (via GitHub)" <gi...@apache.org>.
orionlibs commented on code in PR #1071:
URL: https://github.com/apache/commons-lang/pull/1071#discussion_r1265949881
##########
src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java:
##########
@@ -918,7 +918,8 @@ public void testIsParsable() {
assertFalse(NumberUtils.isParsable("pendro"));
assertFalse(NumberUtils.isParsable("64, 2"));
assertFalse(NumberUtils.isParsable("64.2.2"));
- assertFalse(NumberUtils.isParsable("64."));
+ assertTrue(NumberUtils.isParsable("64."));
Review Comment:
@elharo sorry. My understanding of the ticket is that 64. is true i.e. parseable and valid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] elharo commented on pull request #1071: LANG-1695: NumberUtils::isParseable does not recognise numbers ending in dot
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #1071:
URL: https://github.com/apache/commons-lang/pull/1071#issuecomment-1685254198
One purpose of this method is precisely to avoid using exceptions for flow control.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] LANG-1695: NumberUtils::isParseable does not recognise numbers ending in dot [commons-lang]
Posted by "orionlibs (via GitHub)" <gi...@apache.org>.
orionlibs commented on PR #1071:
URL: https://github.com/apache/commons-lang/pull/1071#issuecomment-1837482638
this PR is still open after half a year
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #1071: LANG-1695
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #1071:
URL: https://github.com/apache/commons-lang/pull/1071#issuecomment-1616719162
> @garydgregory I am new to open source contribution and a week ago I started with Apache. I applied for a JIRA account, but I was denied one (with no reason given). So, I cannot login to JIRA. Here is the email from apache: We regret to inform you that, upon reviewing your request for a new Jira account connected with The Apache Software Foundation, the commons project has chosen to deny the request. We therefore will not create the Jira account.
>
> The following reason was given: No reason given.
>
> If you wish to appeal this decision, you may do so either directly with the commons project, or by contacting the ASF Infrastructure team at: [users@infra.apache.org](mailto:users@infra.apache.org)
What user name and real name did you use in the application? I'll see if I can find the application and rejection in the archives.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] elharo commented on a diff in pull request #1071: LANG-1695: NumberUtils::isParseable does not recognise numbers ending in dot
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #1071:
URL: https://github.com/apache/commons-lang/pull/1071#discussion_r1278287785
##########
src/main/java/org/apache/commons/lang3/math/NumberUtils.java:
##########
@@ -1776,7 +1773,7 @@ private static boolean withDecimalsParsing(final String str, final int beginIdx)
if (decimalPoints > 1) {
return false;
}
- if (!isDecimalPoint && !Character.isDigit(str.charAt(i))) {
+ if (!isDecimalPoint && !Character.isDigit(str.charAt(i)) && !(i == str.length() - 1 && str.charAt(i) == '.')) {
Review Comment:
Per current Javadoc "Parsable numbers include those Strings understood by Integer#parseInt(String), Long#parseLong(String), Float#parseFloat(String)} or Double#parseDouble(String)."
If those methods don't worry about countries that flip the meaning of the comma and period, we shouldn't do it here. That would be a breaking behavior change.
As to another method that uses Locales, that's in java.util so outside the advertised scope for commons-lang.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] elharo commented on a diff in pull request #1071: LANG-1695
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #1071:
URL: https://github.com/apache/commons-lang/pull/1071#discussion_r1261147626
##########
src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java:
##########
@@ -918,7 +918,8 @@ public void testIsParsable() {
assertFalse(NumberUtils.isParsable("pendro"));
assertFalse(NumberUtils.isParsable("64, 2"));
assertFalse(NumberUtils.isParsable("64.2.2"));
- assertFalse(NumberUtils.isParsable("64."));
+ assertTrue(NumberUtils.isParsable("64."));
Review Comment:
please add a test that 64.. is false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] orionlibs commented on pull request #1071: LANG-1695
Posted by "orionlibs (via GitHub)" <gi...@apache.org>.
orionlibs commented on PR #1071:
URL: https://github.com/apache/commons-lang/pull/1071#issuecomment-1616698137
@garydgregory also there are many many open tickets in JIRA for many projects that have actually been completed, but they are still open, with no assignees or comments or anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] elharo commented on pull request #1071: LANG-1695: NumberUtils::isParseable does not recognise numbers ending in dot
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #1071:
URL: https://github.com/apache/commons-lang/pull/1071#issuecomment-1656867208
The more I think about this, the more I'm convinced we should not account for localization. This method is *not* for the purpose of determining whether a string is plausibly a number. Its purpose is to return true or false depending on whether the string can be parsed by one of the java.lang.Number classes. Those classes don't consider localization, so this one shouldn't either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #1071: LANG-1695: NumberUtils::isParseable does not recognise numbers ending in dot
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #1071:
URL: https://github.com/apache/commons-lang/pull/1071#issuecomment-1656841226
To make things more complicated, in the French locale a non-breaking space can be used to separate some items. I can't recall the details now but it's yet another thing to lookout for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] orionlibs commented on pull request #1071: LANG-1695
Posted by "orionlibs (via GitHub)" <gi...@apache.org>.
orionlibs commented on PR #1071:
URL: https://github.com/apache/commons-lang/pull/1071#issuecomment-1617697366
thank you Gary. I just registered again for JIRA with the
email = ***@***.***
username = dimitrios.efthymiou
On Mon, 3 Jul 2023 at 01:40, Gary Gregory ***@***.***> wrote:
> @garydgregory <https://github.com/garydgregory> I am new to open source
> contribution and a week ago I started with Apache. I applied for a JIRA
> account, but I was denied one (with no reason given). So, I cannot login to
> JIRA. Here is the email from apache: We regret to inform you that, upon
> reviewing your request for a new Jira account connected with The Apache
> Software Foundation, the commons project has chosen to deny the request. We
> therefore will not create the Jira account.
>
> The following reason was given: No reason given.
>
> If you wish to appeal this decision, you may do so either directly with
> the commons project, or by contacting the ASF Infrastructure team at:
> ***@***.***
>
> @orionlibs <https://github.com/orionlibs>
> Please apply again for a Jira account, I'll watch for it.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/commons-lang/pull/1071#issuecomment-1617054177>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABGQOMN5ITPI66OJCP5XUBTXOIIIVANCNFSM6AAAAAAZZBH2WU>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] orionlibs commented on pull request #1071: LANG-1695
Posted by "orionlibs (via GitHub)" <gi...@apache.org>.
orionlibs commented on PR #1071:
URL: https://github.com/apache/commons-lang/pull/1071#issuecomment-1616697860
@garydgregory I am new to open source contribution and a week ago I started with Apache. I applied for a JIRA account, but I was denied one (with no reason given). So, I cannot login to JIRA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] orionlibs commented on pull request #1071: LANG-1695
Posted by "orionlibs (via GitHub)" <gi...@apache.org>.
orionlibs commented on PR #1071:
URL: https://github.com/apache/commons-lang/pull/1071#issuecomment-1616720795
> What user name and real name did you use in the application? I'll see if I can find the application and rejection in the archives.
@garydgregory I used this page
https://selfserve.apache.org/jira-account.html
and the info I entered was:
email address = efthymiou.dimitrios1@gmail.com
username = dimitrios.efthymiou
real public name = Dimitrios Efthymiou
tell us the intent for this account = I don't need the account now, but I don't know when I will. It is like when you join a company. They give you access to some basic services. (This was probably the reason, but I didn't know then that I needed access to JIRA in order to update the tickets I worked on. I worked on a few tickets that were unassigned and did not have PR links in them. With a JIRA account I can assign myself to the tickets I work on and I can add my PR links in there. I guess that was the reason they rejected me)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] orionlibs commented on a diff in pull request #1071: LANG-1695: NumberUtils::isParseable does not recognise numbers ending in dot
Posted by "orionlibs (via GitHub)" <gi...@apache.org>.
orionlibs commented on code in PR #1071:
URL: https://github.com/apache/commons-lang/pull/1071#discussion_r1277342044
##########
src/main/java/org/apache/commons/lang3/math/NumberUtils.java:
##########
@@ -1776,7 +1773,7 @@ private static boolean withDecimalsParsing(final String str, final int beginIdx)
if (decimalPoints > 1) {
return false;
}
- if (!isDecimalPoint && !Character.isDigit(str.charAt(i))) {
+ if (!isDecimalPoint && !Character.isDigit(str.charAt(i)) && !(i == str.length() - 1 && str.charAt(i) == '.')) {
Review Comment:
perhaps there could be another method that takes a Locale object. Otherwise, I don't think the current parser should concern itself with it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org