You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2019/07/11 00:17:11 UTC
Review Request 71050: Added Role::reserved, Role::allocated,
Role::offered to master.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71050/
-----------------------------------------------------------
Review request for mesos, Andrei Sekretenko and Meng Zhu.
Bugs: MESOS-8789
https://issues.apache.org/jira/browse/MESOS-8789
Repository: mesos
Description
-------
This provides a breakdown of resource quantities on a per-role
basis, that would aid debugging if shown in the endpoints and
roles table in the ui.
Diffs
-----
src/master/master.hpp 9b861551b0b19666a256730fe711bc32268bf0b7
Diff: https://reviews.apache.org/r/71050/diff/1/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 71050: Added Role::reserved, Role::allocated,
Role::offered to master.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71050/#review216533
-----------------------------------------------------------
Ship it!
Ship It!
- Meng Zhu
On July 11, 2019, 11:35 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71050/
> -----------------------------------------------------------
>
> (Updated July 11, 2019, 11:35 a.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
>
>
> Bugs: MESOS-8789
> https://issues.apache.org/jira/browse/MESOS-8789
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This provides a breakdown of resource quantities on a per-role
> basis, that would aid debugging if shown in the endpoints and
> roles table in the ui.
>
>
> Diffs
> -----
>
> src/master/master.hpp 9b861551b0b19666a256730fe711bc32268bf0b7
>
>
> Diff: https://reviews.apache.org/r/71050/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 71050: Added Role::reserved, Role::allocated,
Role::offered to master.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71050/
-----------------------------------------------------------
(Updated July 11, 2019, 6:35 p.m.)
Review request for mesos, Andrei Sekretenko and Meng Zhu.
Changes
-------
- Added const qualifiers
- Exposed non-scalars
Bugs: MESOS-8789
https://issues.apache.org/jira/browse/MESOS-8789
Repository: mesos
Description
-------
This provides a breakdown of resource quantities on a per-role
basis, that would aid debugging if shown in the endpoints and
roles table in the ui.
Diffs (updated)
-----
src/master/master.hpp 9b861551b0b19666a256730fe711bc32268bf0b7
Diff: https://reviews.apache.org/r/71050/diff/2/
Changes: https://reviews.apache.org/r/71050/diff/1-2/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 71050: Added Role::reserved, Role::allocated,
Role::offered to master.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71050/#review216510
-----------------------------------------------------------
Ship it!
Ship It!
- Meng Zhu
On July 10, 2019, 5:17 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71050/
> -----------------------------------------------------------
>
> (Updated July 10, 2019, 5:17 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
>
>
> Bugs: MESOS-8789
> https://issues.apache.org/jira/browse/MESOS-8789
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This provides a breakdown of resource quantities on a per-role
> basis, that would aid debugging if shown in the endpoints and
> roles table in the ui.
>
>
> Diffs
> -----
>
> src/master/master.hpp 9b861551b0b19666a256730fe711bc32268bf0b7
>
>
> Diff: https://reviews.apache.org/r/71050/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 71050: Added Role::reserved, Role::allocated,
Role::offered to master.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71050/#review216513
-----------------------------------------------------------
src/master/master.hpp
Lines 2800-2801 (patched)
<https://reviews.apache.org/r/71050/#comment303731>
hmm, what if reservation has non-scalar resources? I guess in all cases, we are just showing scalar ones.
But if role `dev` has a reservation of 100 ports, when they hit `/roles`, they will get `reserved : {}`, feels somewhat inappropriate.
- Meng Zhu
On July 10, 2019, 5:17 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71050/
> -----------------------------------------------------------
>
> (Updated July 10, 2019, 5:17 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
>
>
> Bugs: MESOS-8789
> https://issues.apache.org/jira/browse/MESOS-8789
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This provides a breakdown of resource quantities on a per-role
> basis, that would aid debugging if shown in the endpoints and
> roles table in the ui.
>
>
> Diffs
> -----
>
> src/master/master.hpp 9b861551b0b19666a256730fe711bc32268bf0b7
>
>
> Diff: https://reviews.apache.org/r/71050/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 71050: Added Role::reserved, Role::allocated,
Role::offered to master.
Posted by Benjamin Mahler <bm...@apache.org>.
> On July 11, 2019, 12:48 p.m., Andrei Sekretenko wrote:
> > src/master/master.hpp
> > Lines 2786 (patched)
> > <https://reviews.apache.org/r/71050/diff/1/?file=2154330#file2154330line2786>
> >
> > Is there a reason why these three methods have no `const` specifier? Are they different from `consumedQuota()` and `allocatedAndOfferedResources` in regard to const-ness in some non-obvious way?
Ah thanks for catching that! Will add const
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71050/#review216521
-----------------------------------------------------------
On July 11, 2019, 12:17 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71050/
> -----------------------------------------------------------
>
> (Updated July 11, 2019, 12:17 a.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
>
>
> Bugs: MESOS-8789
> https://issues.apache.org/jira/browse/MESOS-8789
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This provides a breakdown of resource quantities on a per-role
> basis, that would aid debugging if shown in the endpoints and
> roles table in the ui.
>
>
> Diffs
> -----
>
> src/master/master.hpp 9b861551b0b19666a256730fe711bc32268bf0b7
>
>
> Diff: https://reviews.apache.org/r/71050/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 71050: Added Role::reserved, Role::allocated,
Role::offered to master.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71050/#review216521
-----------------------------------------------------------
src/master/master.hpp
Lines 2786 (patched)
<https://reviews.apache.org/r/71050/#comment303740>
Is there a reason why these three methods have no `const` specifier? Are they different from `consumedQuota()` and `allocatedAndOfferedResources` in regard to const-ness in some non-obvious way?
- Andrei Sekretenko
On July 11, 2019, 12:17 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71050/
> -----------------------------------------------------------
>
> (Updated July 11, 2019, 12:17 a.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
>
>
> Bugs: MESOS-8789
> https://issues.apache.org/jira/browse/MESOS-8789
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This provides a breakdown of resource quantities on a per-role
> basis, that would aid debugging if shown in the endpoints and
> roles table in the ui.
>
>
> Diffs
> -----
>
> src/master/master.hpp 9b861551b0b19666a256730fe711bc32268bf0b7
>
>
> Diff: https://reviews.apache.org/r/71050/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>