You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/02/19 08:20:02 UTC
[GitHub] [hive] zchovan commented on a change in pull request #1974: HIVE-24772: Revamp Server Request Error Logging
zchovan commented on a change in pull request #1974:
URL: https://github.com/apache/hive/pull/1974#discussion_r578999876
##########
File path: service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java
##########
@@ -302,7 +301,7 @@ public TRenewDelegationTokenResp RenewDelegationToken(TRenewDelegationTokenReq r
hiveAuthFactory, req.getDelegationToken());
resp.setStatus(OK_STATUS);
} catch (HiveSQLException e) {
- LOG.error("Error obtaining renewing token", e);
+ LOG.error("Failed to renewing token [request: {}]", e);
Review comment:
nit: "Failed to renew" instead of "Failed to renewing"
##########
File path: service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java
##########
@@ -283,7 +282,7 @@ public TCancelDelegationTokenResp CancelDelegationToken(TCancelDelegationTokenRe
hiveAuthFactory, req.getDelegationToken());
resp.setStatus(OK_STATUS);
} catch (HiveSQLException e) {
- LOG.error("Error canceling delegation token", e);
+ LOG.error("Failed to canceling delegation token [request: {}]", req, e);
Review comment:
nit: "Failed to cancel" instead of "Failed to canceling"
##########
File path: service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java
##########
@@ -552,7 +554,7 @@ public TGetInfoResp GetInfo(TGetInfoReq req) throws TException {
resp.setInfoValue(getInfoValue.toTGetInfoValue());
resp.setStatus(OK_STATUS);
} catch (Exception e) {
- LOG.warn("Error getting info: ", e);
+ LOG.warn("Error getting info", e);
Review comment:
should this be error level log? or "Failed to get info"
##########
File path: service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java
##########
@@ -536,7 +538,7 @@ public TCloseSessionResp CloseSession(TCloseSessionReq req) throws TException {
context.setSessionHandle(null);
}
} catch (Exception e) {
- LOG.warn("Error closing session: ", e);
+ LOG.warn("Error closing session", e);
Review comment:
should this be error level log? or maybe change it to "Failed to close the session"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org