You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/22 01:48:13 UTC
[GitHub] [shardingsphere] azexcy opened a new pull request, #21689: Revise inventory records count and improve init incremental task progress
azexcy opened a new pull request, #21689:
URL: https://github.com/apache/shardingsphere/pull/21689
Changes proposed in this pull request:
- Revise inventory records count
- improve init incremental task progress
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] azexcy commented on pull request #21689: Revise inventory records count and improve init incremental task progress
Posted by GitBox <gi...@apache.org>.
azexcy commented on PR #21689:
URL: https://github.com/apache/shardingsphere/pull/21689#issuecomment-1287577525
now increment task finished
```
dataSourceName: ds_1
incremental:
delay:
lastEventTimestamps: 1666401396000
latestActiveTimeMillis: 1666401742854
position: binlog.000003#3432139
inventory:
```
then restart proxy, If there is no incremental data coming in, the incremental.delay will be overwritten
```
dataSourceName: ds_1
incremental:
delay:
lastEventTimestamps: 0
latestActiveTimeMillis: 0
position: binlog.000003#3432139
inventory:
```
just like this.
```
mysql> show migration status 'j01019761922f8fab5ce3c61496c22f733586';
+------+-------------+--------------------------+--------+-------------------------+-------------------------------+--------------------------+---------------+
| item | data_source | status | active | processed_records_count | inventory_finished_percentage | incremental_idle_seconds | error_message |
+------+-------------+--------------------------+--------+-------------------------+-------------------------------+--------------------------+---------------+
| 0 | source_ds | EXECUTE_INCREMENTAL_TASK | true | 9 | 100 | 27 | |
+------+-------------+--------------------------+--------+-------------------------+-------------------------------+--------------------------+---------------+
1 row in set (0.20 sec)
mysql> show migration status 'j01019761922f8fab5ce3c61496c22f733586';
ERROR 2013 (HY000): Lost connection to MySQL server during query
No connection. Trying to reconnect...
Connection id: 1
Current database: sharding_db
+------+-------------+--------------------------+--------+-------------------------+-------------------------------+--------------------------+---------------+
| item | data_source | status | active | processed_records_count | inventory_finished_percentage | incremental_idle_seconds | error_message |
+------+-------------+--------------------------+--------+-------------------------+-------------------------------+--------------------------+---------------+
| 0 | source_ds | EXECUTE_INCREMENTAL_TASK | true | 9 | 100 | 0 | |
+------+-------------+--------------------------+--------+-------------------------+-------------------------------+--------------------------+---------------+
1 row in set (2.66 sec)
mysql>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #21689: Revise inventory records count and improve init incremental task progress
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #21689:
URL: https://github.com/apache/shardingsphere/pull/21689#issuecomment-1287589496
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/21689?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21689](https://codecov.io/gh/apache/shardingsphere/pull/21689?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9dcd9fe) into [master](https://codecov.io/gh/apache/shardingsphere/commit/451bf96677dd28a95f6eb348bd418763c6658421?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (451bf96) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #21689 +/- ##
============================================
- Coverage 61.10% 61.09% -0.01%
Complexity 2511 2511
============================================
Files 4111 4111
Lines 57346 57350 +4
Branches 9687 9688 +1
============================================
Hits 35039 35039
- Misses 19399 19403 +4
Partials 2908 2908
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/21689?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...a/pipeline/core/prepare/InventoryTaskSplitter.java](https://codecov.io/gh/apache/shardingsphere/pull/21689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL3ByZXBhcmUvSW52ZW50b3J5VGFza1NwbGl0dGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...phere/data/pipeline/core/task/IncrementalTask.java](https://codecov.io/gh/apache/shardingsphere/pull/21689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL3Rhc2svSW5jcmVtZW50YWxUYXNrLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ne/scenario/migration/MigrationJobItemContext.java](https://codecov.io/gh/apache/shardingsphere/pull/21689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9zY2VuYXJpby9taWdyYXRpb24vTWlncmF0aW9uSm9iSXRlbUNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz merged pull request #21689: Revise inventory records count and improve init incremental task progress
Posted by GitBox <gi...@apache.org>.
sandynz merged PR #21689:
URL: https://github.com/apache/shardingsphere/pull/21689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org