You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/05/01 13:17:41 UTC

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3107: ARTEMIS-2648 - audit logging improvements

clebertsuconic commented on a change in pull request #3107:
URL: https://github.com/apache/activemq-artemis/pull/3107#discussion_r418536427



##########
File path: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/handler/EventHandler.java
##########
@@ -91,4 +91,7 @@ default boolean flowControl(ReadyListener readyListener) {
       return true;
    }
 
+   default String getRemoteAddress() {

Review comment:
       You don't need this. you're using AMQPConnection directly, no need to change to change EventHandler.
   
   Can you remove it?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org