You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Tom White (JIRA)" <ji...@apache.org> on 2011/02/18 02:50:12 UTC

[jira] Created: (MAPREDUCE-2337) Remove dependence of public MapReduce API on classes in server package

Remove dependence of public MapReduce API on classes in server package
----------------------------------------------------------------------

                 Key: MAPREDUCE-2337
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2337
             Project: Hadoop Map/Reduce
          Issue Type: Improvement
            Reporter: Tom White
            Assignee: Tom White


Cluster#getJobTrackerState() returns a org.apache.hadoop.mapreduce.server.jobtracker.State enum, which makes the API in o.a.h.mapreduce have a dependency on the server package. It would be better to make the public API self-contained by using an equivalent enum in the Cluster class.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-2337) Remove dependence of public MapReduce API on classes in server package

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017268#comment-13017268 ] 

Hudson commented on MAPREDUCE-2337:
-----------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #639 (See [https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/639/])
    MAPREDUCE-2337. Remove dependence of public MapReduce API on classes in server package.


> Remove dependence of public MapReduce API on classes in server package
> ----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2337
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2337
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Tom White
>            Assignee: Tom White
>             Fix For: 0.22.0
>
>         Attachments: MAPREDUCE-2337.patch, MAPREDUCE-2337.patch, MAPREDUCE-2337.patch, MAPREDUCE-2337.patch
>
>
> Cluster#getJobTrackerState() returns a org.apache.hadoop.mapreduce.server.jobtracker.State enum, which makes the API in o.a.h.mapreduce have a dependency on the server package. It would be better to make the public API self-contained by using an equivalent enum in the Cluster class.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-2337) Remove dependence of public MapReduce API on classes in server package

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017443#comment-13017443 ] 

Hudson commented on MAPREDUCE-2337:
-----------------------------------

Integrated in Hadoop-Mapreduce-22-branch #39 (See [https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-22-branch/39/])
    Merge -r 1090103:1090104 from trunk to branch-0.22. Fixes: MAPREDUCE-2337


> Remove dependence of public MapReduce API on classes in server package
> ----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2337
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2337
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Tom White
>            Assignee: Tom White
>             Fix For: 0.22.0
>
>         Attachments: MAPREDUCE-2337.patch, MAPREDUCE-2337.patch, MAPREDUCE-2337.patch, MAPREDUCE-2337.patch
>
>
> Cluster#getJobTrackerState() returns a org.apache.hadoop.mapreduce.server.jobtracker.State enum, which makes the API in o.a.h.mapreduce have a dependency on the server package. It would be better to make the public API self-contained by using an equivalent enum in the Cluster class.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (MAPREDUCE-2337) Remove dependence of public MapReduce API on classes in server package

Posted by "Tom White (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998668#comment-12998668 ] 

Tom White commented on MAPREDUCE-2337:
--------------------------------------

bq. It doesn't seem right that ClientProtocol exposes the server-internal state type to me.

Good point. However I think that ClientProtocol (which is Private) should return a mapreduce.Cluster.JobTrackerStatus, just like its getClusterMetrics() method returns a mapreduce.ClusterMetrics object. I'll create a new patch.

> Remove dependence of public MapReduce API on classes in server package
> ----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2337
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2337
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: MAPREDUCE-2337.patch, MAPREDUCE-2337.patch
>
>
> Cluster#getJobTrackerState() returns a org.apache.hadoop.mapreduce.server.jobtracker.State enum, which makes the API in o.a.h.mapreduce have a dependency on the server package. It would be better to make the public API self-contained by using an equivalent enum in the Cluster class.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-2337) Remove dependence of public MapReduce API on classes in server package

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018099#comment-13018099 ] 

Hudson commented on MAPREDUCE-2337:
-----------------------------------

Integrated in Hadoop-Mapreduce-trunk #646 (See [https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/646/])
    

> Remove dependence of public MapReduce API on classes in server package
> ----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2337
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2337
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Tom White
>            Assignee: Tom White
>             Fix For: 0.22.0
>
>         Attachments: MAPREDUCE-2337.patch, MAPREDUCE-2337.patch, MAPREDUCE-2337.patch, MAPREDUCE-2337.patch
>
>
> Cluster#getJobTrackerState() returns a org.apache.hadoop.mapreduce.server.jobtracker.State enum, which makes the API in o.a.h.mapreduce have a dependency on the server package. It would be better to make the public API self-contained by using an equivalent enum in the Cluster class.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (MAPREDUCE-2337) Remove dependence of public MapReduce API on classes in server package

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999327#comment-12999327 ] 

Hadoop QA commented on MAPREDUCE-2337:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12471866/MAPREDUCE-2337.patch
  against trunk revision 1074251.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 12 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these core unit tests:
                  org.apache.hadoop.mapred.TestControlledMapReduceJob

    -1 contrib tests.  The patch failed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/27//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/27//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/27//console

This message is automatically generated.

> Remove dependence of public MapReduce API on classes in server package
> ----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2337
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2337
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: MAPREDUCE-2337.patch, MAPREDUCE-2337.patch, MAPREDUCE-2337.patch
>
>
> Cluster#getJobTrackerState() returns a org.apache.hadoop.mapreduce.server.jobtracker.State enum, which makes the API in o.a.h.mapreduce have a dependency on the server package. It would be better to make the public API self-contained by using an equivalent enum in the Cluster class.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MAPREDUCE-2337) Remove dependence of public MapReduce API on classes in server package

Posted by "Tom White (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom White updated MAPREDUCE-2337:
---------------------------------

    Status: Patch Available  (was: Open)

> Remove dependence of public MapReduce API on classes in server package
> ----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2337
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2337
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: MAPREDUCE-2337.patch, MAPREDUCE-2337.patch, MAPREDUCE-2337.patch
>
>
> Cluster#getJobTrackerState() returns a org.apache.hadoop.mapreduce.server.jobtracker.State enum, which makes the API in o.a.h.mapreduce have a dependency on the server package. It would be better to make the public API self-contained by using an equivalent enum in the Cluster class.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MAPREDUCE-2337) Remove dependence of public MapReduce API on classes in server package

Posted by "Tom White (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom White updated MAPREDUCE-2337:
---------------------------------

    Attachment: MAPREDUCE-2337.patch

New patch which deprecates the equivalent in the old API too, and changes the tests to use the new method.

> Remove dependence of public MapReduce API on classes in server package
> ----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2337
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2337
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: MAPREDUCE-2337.patch, MAPREDUCE-2337.patch
>
>
> Cluster#getJobTrackerState() returns a org.apache.hadoop.mapreduce.server.jobtracker.State enum, which makes the API in o.a.h.mapreduce have a dependency on the server package. It would be better to make the public API self-contained by using an equivalent enum in the Cluster class.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-2337) Remove dependence of public MapReduce API on classes in server package

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017183#comment-13017183 ] 

Todd Lipcon commented on MAPREDUCE-2337:
----------------------------------------

+1

> Remove dependence of public MapReduce API on classes in server package
> ----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2337
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2337
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: MAPREDUCE-2337.patch, MAPREDUCE-2337.patch, MAPREDUCE-2337.patch, MAPREDUCE-2337.patch
>
>
> Cluster#getJobTrackerState() returns a org.apache.hadoop.mapreduce.server.jobtracker.State enum, which makes the API in o.a.h.mapreduce have a dependency on the server package. It would be better to make the public API self-contained by using an equivalent enum in the Cluster class.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (MAPREDUCE-2337) Remove dependence of public MapReduce API on classes in server package

Posted by "Tom White (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom White updated MAPREDUCE-2337:
---------------------------------

    Attachment: MAPREDUCE-2337.patch

Here's a new patch with the above changes.

> Remove dependence of public MapReduce API on classes in server package
> ----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2337
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2337
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: MAPREDUCE-2337.patch, MAPREDUCE-2337.patch, MAPREDUCE-2337.patch
>
>
> Cluster#getJobTrackerState() returns a org.apache.hadoop.mapreduce.server.jobtracker.State enum, which makes the API in o.a.h.mapreduce have a dependency on the server package. It would be better to make the public API self-contained by using an equivalent enum in the Cluster class.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-2337) Remove dependence of public MapReduce API on classes in server package

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017103#comment-13017103 ] 

Todd Lipcon commented on MAPREDUCE-2337:
----------------------------------------

In o.a.h.mapreduce.Cluster#getJobTrackerStatus(), can you delegate that directly to client.getJobTrackerStatus(), rather than calling the now-deprecated getJobTrackerState()?


> Remove dependence of public MapReduce API on classes in server package
> ----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2337
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2337
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: MAPREDUCE-2337.patch, MAPREDUCE-2337.patch, MAPREDUCE-2337.patch
>
>
> Cluster#getJobTrackerState() returns a org.apache.hadoop.mapreduce.server.jobtracker.State enum, which makes the API in o.a.h.mapreduce have a dependency on the server package. It would be better to make the public API self-contained by using an equivalent enum in the Cluster class.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-2337) Remove dependence of public MapReduce API on classes in server package

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017220#comment-13017220 ] 

Hadoop QA commented on MAPREDUCE-2337:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12475752/MAPREDUCE-2337.patch
  against trunk revision 1089686.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 12 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/158//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/158//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/158//console

This message is automatically generated.

> Remove dependence of public MapReduce API on classes in server package
> ----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2337
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2337
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: MAPREDUCE-2337.patch, MAPREDUCE-2337.patch, MAPREDUCE-2337.patch, MAPREDUCE-2337.patch
>
>
> Cluster#getJobTrackerState() returns a org.apache.hadoop.mapreduce.server.jobtracker.State enum, which makes the API in o.a.h.mapreduce have a dependency on the server package. It would be better to make the public API self-contained by using an equivalent enum in the Cluster class.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (MAPREDUCE-2337) Remove dependence of public MapReduce API on classes in server package

Posted by "Tom White (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom White updated MAPREDUCE-2337:
---------------------------------

    Attachment: MAPREDUCE-2337.patch

Fixed. Thanks for the review.

> Remove dependence of public MapReduce API on classes in server package
> ----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2337
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2337
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: MAPREDUCE-2337.patch, MAPREDUCE-2337.patch, MAPREDUCE-2337.patch, MAPREDUCE-2337.patch
>
>
> Cluster#getJobTrackerState() returns a org.apache.hadoop.mapreduce.server.jobtracker.State enum, which makes the API in o.a.h.mapreduce have a dependency on the server package. It would be better to make the public API self-contained by using an equivalent enum in the Cluster class.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (MAPREDUCE-2337) Remove dependence of public MapReduce API on classes in server package

Posted by "Tom White (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom White updated MAPREDUCE-2337:
---------------------------------

    Status: Patch Available  (was: Open)

> Remove dependence of public MapReduce API on classes in server package
> ----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2337
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2337
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: MAPREDUCE-2337.patch, MAPREDUCE-2337.patch
>
>
> Cluster#getJobTrackerState() returns a org.apache.hadoop.mapreduce.server.jobtracker.State enum, which makes the API in o.a.h.mapreduce have a dependency on the server package. It would be better to make the public API self-contained by using an equivalent enum in the Cluster class.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MAPREDUCE-2337) Remove dependence of public MapReduce API on classes in server package

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998591#comment-12998591 ] 

Todd Lipcon commented on MAPREDUCE-2337:
----------------------------------------

I think this makes sense, but maybe it actually should get pushed into the protocol package? ie the new State enum should be part of ClientProtocol, and ClientProtocol.getJobTrackerStatus() would return the new type while deprecating ClientProtocol.getJobTrackerState? It doesn't seem right that ClientProtocol exposes the server-internal state type to me.

> Remove dependence of public MapReduce API on classes in server package
> ----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2337
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2337
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: MAPREDUCE-2337.patch, MAPREDUCE-2337.patch
>
>
> Cluster#getJobTrackerState() returns a org.apache.hadoop.mapreduce.server.jobtracker.State enum, which makes the API in o.a.h.mapreduce have a dependency on the server package. It would be better to make the public API self-contained by using an equivalent enum in the Cluster class.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MAPREDUCE-2337) Remove dependence of public MapReduce API on classes in server package

Posted by "Tom White (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999631#comment-12999631 ] 

Tom White commented on MAPREDUCE-2337:
--------------------------------------

The test failures are unrelated.

> Remove dependence of public MapReduce API on classes in server package
> ----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2337
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2337
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: MAPREDUCE-2337.patch, MAPREDUCE-2337.patch, MAPREDUCE-2337.patch
>
>
> Cluster#getJobTrackerState() returns a org.apache.hadoop.mapreduce.server.jobtracker.State enum, which makes the API in o.a.h.mapreduce have a dependency on the server package. It would be better to make the public API self-contained by using an equivalent enum in the Cluster class.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MAPREDUCE-2337) Remove dependence of public MapReduce API on classes in server package

Posted by "Tom White (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom White updated MAPREDUCE-2337:
---------------------------------

    Attachment: MAPREDUCE-2337.patch

Patch which deprecates the method and enum in favour of new ones in Cluster.

> Remove dependence of public MapReduce API on classes in server package
> ----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2337
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2337
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: MAPREDUCE-2337.patch
>
>
> Cluster#getJobTrackerState() returns a org.apache.hadoop.mapreduce.server.jobtracker.State enum, which makes the API in o.a.h.mapreduce have a dependency on the server package. It would be better to make the public API self-contained by using an equivalent enum in the Cluster class.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MAPREDUCE-2337) Remove dependence of public MapReduce API on classes in server package

Posted by "Tom White (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom White updated MAPREDUCE-2337:
---------------------------------

    Status: Open  (was: Patch Available)

> Remove dependence of public MapReduce API on classes in server package
> ----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2337
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2337
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: MAPREDUCE-2337.patch, MAPREDUCE-2337.patch
>
>
> Cluster#getJobTrackerState() returns a org.apache.hadoop.mapreduce.server.jobtracker.State enum, which makes the API in o.a.h.mapreduce have a dependency on the server package. It would be better to make the public API self-contained by using an equivalent enum in the Cluster class.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-2337) Remove dependence of public MapReduce API on classes in server package

Posted by "Tom White (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom White updated MAPREDUCE-2337:
---------------------------------

       Resolution: Fixed
    Fix Version/s: 0.22.0
     Hadoop Flags: [Reviewed]
           Status: Resolved  (was: Patch Available)

I've just committed this.

> Remove dependence of public MapReduce API on classes in server package
> ----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2337
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2337
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Tom White
>            Assignee: Tom White
>             Fix For: 0.22.0
>
>         Attachments: MAPREDUCE-2337.patch, MAPREDUCE-2337.patch, MAPREDUCE-2337.patch, MAPREDUCE-2337.patch
>
>
> Cluster#getJobTrackerState() returns a org.apache.hadoop.mapreduce.server.jobtracker.State enum, which makes the API in o.a.h.mapreduce have a dependency on the server package. It would be better to make the public API self-contained by using an equivalent enum in the Cluster class.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira