[GitHub] [beam] hmc-cs-mdrissi edited a comment on pull request #15415: [BEAM-12000] Update deprecated collections to use collections.abc in python sdk

[GitBox <gi...@apache.org>]

hmc-cs-mdrissi edited a comment on pull request #15415:
URL: https://github.com/apache/beam/pull/15415#issuecomment-918988026


   I've updated the import to cover collections.abc. I'm unsure why the tests are fine as some tests definitely do pass by those lines based on adding breakpoints, but better to be safe. Most likely reason why tests are fine is that some other import indirectly adds collections.abc. It's a common library to import so most of the time you will get somewhere.
   
   PR status was mainly I needed to get dev environment set up. Back when I made the pr I made the edits without setting up an environment. Now that I've got beam locally set up, I added a simple unit test that should hopefully fix coverage failure. Coverage failure was only thing blocking the pr earlier. For coverage I noticed overload lines were counting as untyped when they should be skipped so added overload to exclude_lines.
   
   RAT precommit hook error confuses me, 
   
   ```
   * What went wrong:
   09:37:41 Execution failed for task ':rat'.
   09:37:41 > A failure occurred while executing org.nosphere.apache.rat.RatWork
   09:37:41    > Apache Rat audit failure - 1 unapproved license
   09:37:41      	See file:///home/jenkins/jenkins-slave/workspace/beam_PreCommit_RAT_Commit/src/build/reports/rat/index.html
   09:37:41 
   09:37:41 * Try:
   09:37:41 Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
   09:37:41 
   ```
   
   pylint error I'll fix in a bit.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org