You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@synapse.apache.org by ve...@apache.org on 2008/05/03 17:18:49 UTC

svn commit: r653090 - /synapse/trunk/java/modules/transports/src/main/java/org/apache/synapse/transport/vfs/VFSTransportSender.java

Author: veithen
Date: Sat May  3 08:18:49 2008
New Revision: 653090

URL: http://svn.apache.org/viewvc?rev=653090&view=rev
Log:
Use a simpler, more efficient and more reliable way to count the number of bytes sent.

Modified:
    synapse/trunk/java/modules/transports/src/main/java/org/apache/synapse/transport/vfs/VFSTransportSender.java

Modified: synapse/trunk/java/modules/transports/src/main/java/org/apache/synapse/transport/vfs/VFSTransportSender.java
URL: http://svn.apache.org/viewvc/synapse/trunk/java/modules/transports/src/main/java/org/apache/synapse/transport/vfs/VFSTransportSender.java?rev=653090&r1=653089&r2=653090&view=diff
==============================================================================
--- synapse/trunk/java/modules/transports/src/main/java/org/apache/synapse/transport/vfs/VFSTransportSender.java (original)
+++ synapse/trunk/java/modules/transports/src/main/java/org/apache/synapse/transport/vfs/VFSTransportSender.java Sat May  3 08:18:49 2008
@@ -30,11 +30,11 @@
 import org.apache.axis2.description.TransportOutDescription;
 import org.apache.commons.vfs.*;
 import org.apache.commons.vfs.impl.StandardFileSystemManager;
+import org.apache.commons.io.output.CountingOutputStream;
 import org.apache.commons.logging.LogFactory;
 import org.apache.axiom.om.OMOutputFormat;
 import org.apache.axiom.om.OMElement;
 
-import java.io.OutputStream;
 import java.io.IOException;
 
 /**
@@ -194,12 +194,15 @@
         // Write the message to the file using the selected message formatter
         OMOutputFormat format = BaseUtils.getOMOutputFormat(msgContext);
         try {
-            OutputStream os = responseFile.getContent().getOutputStream();
+            CountingOutputStream os = new CountingOutputStream(responseFile.getContent().getOutputStream());
             try {
                 messageFormatter.writeTo(msgContext, format, os, true);
             } finally {
                 os.close();
             }
+            // update metrics
+            metrics.incrementMessagesSent();
+            metrics.incrementBytesSent(os.getByteCount());
         } catch (FileSystemException e) {
             metrics.incrementFaultsSending();
             handleException("IO Error while creating response file : " + responseFile.getName(), e);
@@ -207,15 +210,5 @@
             metrics.incrementFaultsSending();
             handleException("IO Error while creating response file : " + responseFile.getName(), e);
         }
-
-        // update metrics
-        metrics.incrementMessagesSent();
-        try {
-            if (responseFile != null && responseFile.getContent() != null) {
-                metrics.incrementBytesSent(responseFile.getContent().getSize());
-            }
-        } catch (FileSystemException e) {
-            log.warn("Unable to update transport metrics for file written", e);
-        }
     }
 }